Re: [PATCH v6 12/12] test: efi: boot: Add a test for the efi bootmeth

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On Mon, Oct 14, 2024 at 01:13:41PM -0600, Simon Glass wrote:

[snip]
> Or perhaps just have a way to turn it off? I first sent this patch
> last November. It is just wrong to generate output like this which we
> don't want. There isn't even a test for it, so just add a way to
> disable it, and be done!

I don't know that it's unwanted. As I'm trying to get Heinrich to
explain, _why_ does efi_setup_console_size need to exist, and do what it
does? This isn't the case of color-coding the output of tests as they
happen, there must be a reason we care about knowing the console size.
At that point we can figure out if the right answer is:
- Don't generate that check on serial ports, it's somewhere between
  misleading to wrong.
- text-based tests just need to expect and skip it because there's a
  good reason to need to know the console size and not just assume
  80x24.
- Something else we won't know until it's clearly explained why we do
  this.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]