From: Conor Dooley <conor@kernel.org>
To: Karan Sanghavi <karansanghvi98@gmail.com>
Cc: krzysztof.kozlowski@linaro.org,
bcm-kernel-feedback-list@broadcom.com, broonie@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
florian.fainelli@broadcom.com, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
rjui@broadcom.com, robh+dt@kernel.org, sbranden@broadcom.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to
Date: Tue, 15 Oct 2024 21:25:35 +0100 [thread overview]
Message-ID: <20241015-proactive-backlog-b77c42eef79c@spud> (raw)
In-Reply-To: <20241015180906.8464-2-karansanghvi98@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]
On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote:
> Converted the brcm,bcm2835-aux-spi.txt file to
> its respective yaml file format.
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> v1->v2 : Made the necessary changes in the yaml file
> suggested by Krzysztof Kozlowski
>
> v1:
> - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/
I don't understand this patch. How is it converting a text file to
json schema when all you're doing here is deleting stuff from an
existing yaml file?
>
> .../bindings/spi/brcm,bcm2835-aux-spi.yaml | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> index 4c24cf2fe214..f83f71ba78dc 100644
> --- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> @@ -9,8 +9,7 @@ title: Broadcom BCM2835 Auxiliary SPI1/2 Controller
> maintainers:
> - Karan Sanghavi <karansanghvi98@gmail.com>
>
> -description: |
> - The BCM2835 contains two forms of SPI master controller. One is known simply as
> +description: The BCM2835 contains two forms of SPI master controller. One is known simply as
> SPI0, and the other as the "Universal SPI Master," part of the auxiliary block.
> This binding applies to the SPI1 and SPI2 auxiliary controllers.
>
> @@ -21,7 +20,6 @@ properties:
> compatible:
> enum:
> - brcm,bcm2835-aux-spi
> - description: Broadcom BCM2835 Auxiliary SPI controller for SPI1 and SPI2.
>
> reg:
> maxItems: 1
> @@ -30,8 +28,7 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: Reference to the auxiliary clock driver for the BCM2835.
> + maxItems: 1
>
> required:
> - compatible
> @@ -53,14 +50,3 @@ examples:
> #size-cells = <0>;
> };
>
> - - |
> - #include <dt-bindings/clock/bcm2835-aux.h>
> - spi@7e2150c0 {
> - compatible = "brcm,bcm2835-aux-spi";
> - reg = <0x7e2150c0 0x40>;
> - interrupts = <1 29>;
> - clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> - };
> -
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-10-15 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 17:02 [PATCH] dt-bindings: spi: Add bcm2835-aux-spi.yaml file Karan Sanghavi
2024-10-14 17:57 ` Krzysztof Kozlowski
2024-10-15 18:09 ` [PATCH v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to Karan Sanghavi
2024-10-15 20:25 ` Conor Dooley [this message]
2024-10-16 10:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015-proactive-backlog-b77c42eef79c@spud \
--to=conor@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=karansanghvi98@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.