All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	stefani@seibold.net, jassisinghbrar@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h
Date: Tue, 15 Oct 2024 09:57:10 +0200	[thread overview]
Message-ID: <20241015075710.GC25487@lst.de> (raw)
In-Reply-To: <f5469873-f099-4926-883a-37badec904df@kernel.org>

On Tue, Oct 15, 2024 at 09:55:06AM +0200, Jiri Slaby wrote:
>> Because it would not comple with out it.  To be specific: asm/io.h is
>> where __raw_readl and __raw_writel are defined, and we generally prefer
>> the Linux over the asm headers.
>
> OK, but how does this relate to "kfifo: don't include dma-mapping.h in 
> kfifo.h"?

Because before that it get io.h pulled in through our batshit crazy
header depency chain. 

  reply	other threads:[~2024-10-15  7:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 14:46 [PATCH] kfifo: don't include dma-mapping.h in kfifo.h Christoph Hellwig
2024-10-15  7:38 ` Jiri Slaby
2024-10-15  7:40   ` Christoph Hellwig
2024-10-15  7:53     ` Jiri Slaby
2024-10-15  7:56       ` Christoph Hellwig
2024-10-15  8:19         ` Jiri Slaby
2024-10-15  7:47 ` Jiri Slaby
2024-10-15  7:50   ` Christoph Hellwig
2024-10-15  7:55     ` Jiri Slaby
2024-10-15  7:57       ` Christoph Hellwig [this message]
2024-10-15  8:03         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015075710.GC25487@lst.de \
    --to=hch@lst.de \
    --cc=jassisinghbrar@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.