From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests/net: Fix ./ns-XXXXXX not cleanup
Date: Tue, 15 Oct 2024 08:43:34 -0700 [thread overview]
Message-ID: <20241015084334.07bf266d@kernel.org> (raw)
In-Reply-To: <20241015010817.453539-2-lizhijian@fujitsu.com>
On Tue, 15 Oct 2024 09:08:16 +0800 Li Zhijian wrote:
> ```
> readonly STATS="$(mktemp -p /tmp ns-XXXXXX)"
> readonly BASE=`basename $STATS`
> ```
> It would be a mistake to write to $BASE rather than $STATS, where $STATS
> is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Shuah already mentioned this, this patch needs to be posted separately
as it would go via the networking tree.
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-15 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 1:08 [PATCH 1/3] selftests: Add a few missing gitignore files Li Zhijian
2024-10-15 1:08 ` [PATCH 2/3] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian
2024-10-15 15:43 ` Jakub Kicinski [this message]
2024-10-15 1:08 ` [PATCH 3/3] selftests: ignore output files and clean them in Makefile Li Zhijian
2024-10-15 15:56 ` Shuah Khan
2024-10-15 15:38 ` [PATCH 1/3] selftests: Add a few missing gitignore files Shuah Khan
2024-10-16 0:42 ` Zhijian Li (Fujitsu)
2024-10-17 20:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015084334.07bf266d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.