Re: [PATCH v2 3/3] examples/ptpclient: add frequency adjustment support

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri,  6 Sep 2024 05:19:39 +0000
Mingjin Ye <mingjinx.ye@intel.com> wrote:

> This patch adds PI servo algorithm to support frequency
> adjustment API for IEEE1588 PTP.
> 
> For example, the command for starting ptpclient with PI algorithm is:
> ./build/examples/dpdk-ptpclient -a 0000:81:00.0 -c 1 -n 3 -- -T 0 -p 0x1
> --controller=pi
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>

Looks like missing include, build is failing

*Build Failed #1:
OS: OpenAnolis8.9-64
Target: x86_64-native-linuxapp-gcc
FAILED: examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o 
gcc -Iexamples/dpdk-ptpclient.p -Iexamples -I../examples -Iexamples/ptpclient -I../examples/ptpclient -I../examples/common -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -march=native -mrtm -Wno-format-truncation -DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o -MF examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o.d -o examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o -c ../examples/ptpclient/ptpclient.c
../examples/ptpclient/ptpclient.c: In function ‘port_init’:
../examples/ptpclient/ptpclient.c:302:12: error: implicit declaration of function ‘rte_eth_timesync_adjust_freq’; did you mean ‘rte_eth_timesync_adjust_time’? [-Werror=implicit-function-declaration]
   retval = rte_eth_timesync_adjust_freq(port, 0);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
            rte_eth_timesync_adjust_time
../examples/ptpclient/ptpclient.c:302:12: error: nested extern declaration of ‘rte_eth_timesync_adjust_freq’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
[2975/3043] Generating examples/multi_process/simple_mp/commands_hdr with a custom command (wrapped by meson to capture output)
[2976/3043] Linking target examples/dpdk-l2fwd-keepalive
[2977/3043] Linking target examples/dpdk-l3fwd-graph
[2978/3043] Linking target examples/dpdk-l3fwd
[2979/3043] Compiling C object examples/dpdk-l3fwd-power.p/l3fwd-power_main.c.o
[2980/3043] Compiling C object examples/dpdk-mp_server.p/multi_process_client_server_mp_mp_server_main.c.o
[2981/3043] Linking target examples/dpdk-l2fwd-macsec
[2982/3043] Linking target examples/dpdk-hotplug_mp
[2983/3043] Linking target examples/dpdk-link_status_interrupt
ninja: build stopped