From: Jakub Kicinski <kuba@kernel.org>
To: Peter Rashleigh <peter@rashleigh.ca>
Cc: andrew@lunn.ch, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x
Date: Tue, 15 Oct 2024 17:49:24 -0700 [thread overview]
Message-ID: <20241015174924.21725f5a@kernel.org> (raw)
In-Reply-To: <CAOai=UuBxxfdu8HsnZi3CmWzZR=zBc_v0A624uTwfKUDRkrwiQ@mail.gmail.com>
On Mon, 14 Oct 2024 14:25:44 -0700 Peter Rashleigh wrote:
> mv88e6393x_port_set_policy doesn't correctly shift the ptr value when
> converting the policy format between the old and new styles, so the
> target register ends up with the ptr being written over the data bits.
>
> Shift the pointer to align with the format expected by
> mv88e6393x_port_policy_write().
>
> Fixes: 6584b26020fc ("net: dsa: mv88e6xxx: implement .port_set_policy
> for Amethyst")
> Signed-off-by: Peter Rashleigh <peter@rashleigh.ca>
the patch has been line-wrapped and whitespace corrupted by either your
email client or server. Please resend.
--
pw-bot: cr
prev parent reply other threads:[~2024-10-16 0:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 21:25 [PATCH net] net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x Peter Rashleigh
2024-10-16 0:49 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015174924.21725f5a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=peter@rashleigh.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.