From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3 3/9] can: m_can: Map WoL to device_set_wakeup_enable
Date: Tue, 15 Oct 2024 20:07:23 +0800 [thread overview]
Message-ID: <202410151950.6UahbF47-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241011-topic-mcan-wakeup-source-v6-12-v3-3-9752c714ad12@baylibre.com>
References: <20241011-topic-mcan-wakeup-source-v6-12-v3-3-9752c714ad12@baylibre.com>
TO: "Markus Schneider-Pargmann" <msp@baylibre.com>
Hi Markus,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9852d85ec9d492ebef56dc5f229416c925758edc]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/dt-bindings-can-m_can-Add-wakeup-properties/20241011-212232
base: 9852d85ec9d492ebef56dc5f229416c925758edc
patch link: https://lore.kernel.org/r/20241011-topic-mcan-wakeup-source-v6-12-v3-3-9752c714ad12%40baylibre.com
patch subject: [PATCH v3 3/9] can: m_can: Map WoL to device_set_wakeup_enable
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-141-20241015 (https://download.01.org/0day-ci/archive/20241015/202410151950.6UahbF47-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202410151950.6UahbF47-lkp@intel.com/
smatch warnings:
drivers/net/can/m_can/m_can.c:2199 m_can_set_wol() warn: add some parenthesis here?
vim +2199 drivers/net/can/m_can/m_can.c
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2195
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2196 static int m_can_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2197 {
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2198 struct m_can_classdev *cdev = netdev_priv(dev);
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 @2199 bool wol_enable = !!wol->wolopts & WAKE_PHY;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2200 int ret;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2201
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2202 if ((wol->wolopts & WAKE_PHY) != wol->wolopts)
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2203 return -EINVAL;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2204
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2205 if (wol_enable == device_may_wakeup(cdev->dev))
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2206 return 0;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2207
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2208 ret = device_set_wakeup_enable(cdev->dev, wol_enable);
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2209 if (ret) {
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2210 netdev_err(cdev->net, "Failed to set wakeup enable %pE\n",
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2211 ERR_PTR(ret));
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2212 return ret;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2213 }
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2214
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2215 return 0;
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2216 }
0bd6199a58d117 Markus Schneider-Pargmann 2024-10-11 2217
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-10-15 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:07 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-11 13:16 [PATCH v3 0/9] can: m_can: Add am62 wakeup support Markus Schneider-Pargmann
2024-10-11 13:16 ` [PATCH v3 3/9] can: m_can: Map WoL to device_set_wakeup_enable Markus Schneider-Pargmann
2024-10-11 18:59 ` Simon Horman
2024-10-15 6:32 ` Markus Schneider-Pargmann
2024-10-15 12:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410151950.6UahbF47-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.