From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hare@suse.de,
martin.petersen@oracle.com, catherine.hoang@oracle.com,
mcgrof@kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v9 3/8] block: Add bdev atomic write limits helpers
Date: Wed, 16 Oct 2024 14:29:19 +0200 [thread overview]
Message-ID: <20241016122919.GA18025@lst.de> (raw)
In-Reply-To: <20241016100325.3534494-4-john.g.garry@oracle.com>
On Wed, Oct 16, 2024 at 10:03:20AM +0000, John Garry wrote:
> +static inline unsigned int
> +bdev_atomic_write_unit_min_bytes(struct block_device *bdev)
> +{
> + if (!bdev_can_atomic_write(bdev))
> + return 0;
Aren't the limits always zero when the block device doesn't support
atomic writes and we can skip these checks?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-16 12:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:03 [PATCH v9 0/8] block atomic writes for xfs John Garry
2024-10-16 10:03 ` [PATCH v9 1/8] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-16 10:03 ` [PATCH v9 2/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-16 19:57 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 3/8] block: Add bdev atomic write limits helpers John Garry
2024-10-16 12:29 ` Christoph Hellwig [this message]
2024-10-16 12:36 ` John Garry
2024-10-16 12:39 ` Christoph Hellwig
2024-10-16 19:58 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 4/8] fs: Export generic_atomic_write_valid() John Garry
2024-10-16 10:03 ` [PATCH v9 5/8] fs: iomap: Atomic write support John Garry
2024-10-16 20:03 ` Darrick J. Wong
2024-10-17 7:57 ` John Garry
2024-10-16 10:03 ` [PATCH v9 6/8] xfs: Support atomic write for statx John Garry
2024-10-16 10:03 ` [PATCH v9 7/8] xfs: Validate atomic writes John Garry
2024-10-16 12:29 ` Christoph Hellwig
2024-10-16 20:13 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 8/8] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-10-16 20:13 ` Darrick J. Wong
2024-10-18 9:29 ` [PATCH v9 0/8] block atomic writes for xfs John Garry
2024-10-18 13:41 ` Jens Axboe
2024-10-18 17:43 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016122919.GA18025@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.