From: Philipp Stanner <pstanner@redhat.com>
To: "Jonathan Corbet" <corbet@lwn.net>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Arnaud Ebalard" <arno@natisbad.org>,
"Srujana Challa" <schalla@marvell.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Philipp Stanner" <pstanner@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jie Wang" <jie.wang@intel.com>,
"Tero Kristo" <tero.kristo@linux.intel.com>,
"Adam Guerin" <adam.guerin@intel.com>,
"Shashank Gupta" <shashank.gupta@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Bharat Bhushan" <bbhushan2@marvell.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Yedidya Benshimol" <yedidya.ben.shimol@intel.com>,
"Breno Leitao" <leitao@debian.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, qat-linux@intel.com,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org,
ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-serial@vger.kernel.org, linux-sound@vger.kernel.org
Subject: [PATCH v4 06/10] wifi: iwlwifi: replace deprecated PCI functions
Date: Wed, 16 Oct 2024 14:41:28 +0200 [thread overview]
Message-ID: <20241016124136.41540-7-pstanner@redhat.com> (raw)
In-Reply-To: <20241016124136.41540-1-pstanner@redhat.com>
pcim_iomap_table() and pcim_iomap_regions_request_all() have been
deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").
Replace these functions with their successors, pcim_iomap() and
pcim_request_all_regions().
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
index 3b9943eb6934..4b41613ad89d 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -3533,7 +3533,6 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
struct iwl_trans_pcie *trans_pcie, **priv;
struct iwl_trans *trans;
int ret, addr_size;
- void __iomem * const *table;
u32 bar0;
/* reassign our BAR 0 if invalid due to possible runtime PM races */
@@ -3659,22 +3658,15 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
}
}
- ret = pcim_iomap_regions_request_all(pdev, BIT(0), DRV_NAME);
+ ret = pcim_request_all_regions(pdev, DRV_NAME);
if (ret) {
- dev_err(&pdev->dev, "pcim_iomap_regions_request_all failed\n");
+ dev_err(&pdev->dev, "pcim_request_all_regions failed\n");
goto out_no_pci;
}
- table = pcim_iomap_table(pdev);
- if (!table) {
- dev_err(&pdev->dev, "pcim_iomap_table failed\n");
- ret = -ENOMEM;
- goto out_no_pci;
- }
-
- trans_pcie->hw_base = table[0];
+ trans_pcie->hw_base = pcim_iomap(pdev, 0, 0);
if (!trans_pcie->hw_base) {
- dev_err(&pdev->dev, "couldn't find IO mem in first BAR\n");
+ dev_err(&pdev->dev, "pcim_iomap failed\n");
ret = -ENODEV;
goto out_no_pci;
}
--
2.47.0
next prev parent reply other threads:[~2024-10-16 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 12:41 [PATCH v4 00/10] Remove pcim_iomap_regions_request_all() Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 01/10] PCI: Make pcim_request_all_regions() a public function Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 02/10] ata: ahci: Replace deprecated PCI functions Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 03/10] crypto: qat - replace " Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 04/10] crypto: marvell " Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 05/10] intel_th: pci: Replace " Philipp Stanner
2024-10-24 11:48 ` Alexander Shishkin
2024-10-16 12:41 ` Philipp Stanner [this message]
2024-10-16 12:41 ` [PATCH v4 07/10] ntb: idt: " Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 08/10] serial: rp2: " Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 09/10] ALSA: korg1212: " Philipp Stanner
2024-10-16 12:41 ` [PATCH v4 10/10] PCI: Remove pcim_iomap_regions_request_all() Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016124136.41540-7-pstanner@redhat.com \
--to=pstanner@redhat.com \
--cc=adam.guerin@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=allenbh@gmail.com \
--cc=arno@natisbad.org \
--cc=bbhushan2@marvell.com \
--cc=bbrezillon@kernel.org \
--cc=benjamin.berg@intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cassel@kernel.org \
--cc=cernekee@gmail.com \
--cc=corbet@lwn.net \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dlechner@baylibre.com \
--cc=dlemoal@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.greenman@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jie.wang@intel.com \
--cc=jirislaby@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=ntb@lists.linux.dev \
--cc=perex@perex.cz \
--cc=przemyslaw.kitszel@intel.com \
--cc=qat-linux@intel.com \
--cc=schalla@marvell.com \
--cc=shashank.gupta@intel.com \
--cc=tero.kristo@linux.intel.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yedidya.ben.shimol@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.