All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: duplicate patches in the regulator tree
Date: Wed, 16 Oct 2024 14:09:24 +0100	[thread overview]
Message-ID: <20241016130924.GB1152434@google.com> (raw)
In-Reply-To: <4bb56093-5358-4d3b-aba8-f8815d2347a6@sirena.org.uk>

On Wed, 16 Oct 2024, Mark Brown wrote:

> On Wed, Oct 16, 2024 at 08:55:10AM +0100, Lee Jones wrote:
> > On Wed, 16 Oct 2024, Stephen Rothwell wrote:
> 
> > > The following commits are also in the mfd tree as different commits
> > > (but the same patches):
> 
> > >   d7a5f27342a8 ("mfd: sec-core: add s2dos05 support")
> > >   ef9690c04f3b ("dt-bindings: mfd: add samsung,s2dos05")
> 
> > And these ones do not follow the style expected by the subsystem.
> 
> > Mark can you please remove these without reverting and further dirtying
> > MFD's history please?  One little rebase isn't going to hurt in the long
> > run. :)
> 
> There's additional stuff on top of them now and I'm not clear that the
> regulator patch would build without the MFD.  I don't understand why you
> said to apply the patches after I'd reviewed the regulator patch,
> usually you insist on waiting until all other subsystems have reviewed
> before applying the MFD cores :(

I said to apply the regulator patch because it looked like it didn't
have any dependencies.  The latter part was my mistake as now I see that
it did have deps.

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-10-16 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  2:59 linux-next: duplicate patches in the regulator tree Stephen Rothwell
2024-10-16  7:55 ` Lee Jones
2024-10-16 11:33   ` Mark Brown
2024-10-16 13:09     ` Lee Jones [this message]
2024-10-22 20:03       ` Mark Brown
2024-10-25  8:51         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016130924.GB1152434@google.com \
    --to=lee@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.