From: Simon Horman <horms@kernel.org>
To: boehm.jakub@gmail.com
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] net: plip: fix break; causing plip to never transmit
Date: Wed, 16 Oct 2024 15:17:15 +0100 [thread overview]
Message-ID: <20241016141715.GH2162@kernel.org> (raw)
In-Reply-To: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com>
On Tue, Oct 15, 2024 at 05:16:04PM +0200, Jakub Boehm via B4 Relay wrote:
> From: Jakub Boehm <boehm.jakub@gmail.com>
>
> Since commit
> 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
>
> plip was not able to send any packets, this patch replaces one
> unintended break; with fallthrough; which was originally missed by
> commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").
>
> I have verified with a real hardware PLIP connection that everything
> works once again after applying this patch.
>
> Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
> Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-16 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 15:16 [PATCH] net: plip: fix break; causing plip to never transmit Jakub Boehm
2024-10-15 15:16 ` Jakub Boehm via B4 Relay
2024-10-16 14:17 ` Simon Horman [this message]
2024-10-20 14:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016141715.GH2162@kernel.org \
--to=horms@kernel.org \
--cc=boehm.jakub@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.