All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Karan Sanghavi <karansanghvi98@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] selftests: tc-testing: Fix spelling errors in cgroup.json and flow.json
Date: Wed, 16 Oct 2024 15:21:35 +0100	[thread overview]
Message-ID: <20241016142135.GI2162@kernel.org> (raw)
In-Reply-To: <Zw6flhHF50_4jT4b@Emma>

On Tue, Oct 15, 2024 at 05:00:06PM +0000, Karan Sanghavi wrote:
> This patch corrects typographical errors in the "name" fields of
> the JSON objects with IDs "4319" and "4341" in the tc-testing
> selftests.
> 
> - "diffferent" is corrected to "different".
> - "muliple" is corrected to "multiple".
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> 
> v3:
> - Corrected the change logs to make it easy to understand. 
> 
> v2:
> - Combine two earlier patches into one
> - Links to v1 of each patch
>   [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
>   [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/
> 
>  tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
>  tools/testing/selftests/tc-testing/tc-tests/filters/flow.json   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> index 03723cf84..6897ff5ad 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> @@ -1189,7 +1189,7 @@
>      },
>      {
>          "id": "4319",
> -        "name": "Replace cgroup filter with diffferent match",
> +        "name": "Replace cgroup filter with different match",
>          "category": [
>              "filter",
>              "cgroup"

Hi Karan,

It seems that multiple is also misspelt several as miltiple in cgroup.json,
basic.json and route.json. While you are fixing spelling here could you fix
that too?

> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> index 58189327f..996448afe 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> @@ -507,7 +507,7 @@
>      },
>      {
>          "id": "4341",
> -        "name": "Add flow filter with muliple ops",
> +        "name": "Add flow filter with multiple ops",
>          "category": [
>              "filter",
>              "flow"
> -- 
> 2.43.0
> 
> 

      reply	other threads:[~2024-10-16 14:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 17:00 [PATCH v3] selftests: tc-testing: Fix spelling errors in cgroup.json and flow.json Karan Sanghavi
2024-10-16 14:21 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016142135.GI2162@kernel.org \
    --to=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=karansanghvi98@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.