From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joy Chakraborty <joychakr@google.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: dwc3: Program USB Gen2 De-emphasis defined in PIPE4 spec
Date: Wed, 16 Oct 2024 10:16:01 +0200 [thread overview]
Message-ID: <2024101635-clergyman-dyslexia-9c75@gregkh> (raw)
In-Reply-To: <20241007135508.3143756-5-joychakr@google.com>
On Mon, Oct 07, 2024 at 01:55:08PM +0000, Joy Chakraborty wrote:
> Set 18bit TxDeemph[17:0] in LCSR_TX_DEEMPH(n) register for USB3 Gen2
> Normal Operation as defined in PIPE4 spec based on dt quirk
> "snps,tx_gen2_de_emphasis_quirk" and "snps,tx_gen2_de_emphasis".
>
> Signed-off-by: Joy Chakraborty <joychakr@google.com>
> ---
> drivers/usb/dwc3/core.c | 13 +++++++++++++
> drivers/usb/dwc3/core.h | 6 ++++++
> 2 files changed, 19 insertions(+)
Any reason why we got 2 copies of all of these in the same series?
Please fix that up for when you send a v2 of them.
thanks,
greg k-h
prev parent reply other threads:[~2024-10-16 8:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 13:55 [PATCH 0/2] usb: dwc3: Add USB3 Gen2 De-emphasis setting from DT Joy Chakraborty
2024-10-07 13:55 ` [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis Joy Chakraborty
2024-10-07 14:56 ` Krzysztof Kozlowski
2024-10-08 10:23 ` Joy Chakraborty
2024-10-08 11:23 ` Krzysztof Kozlowski
2024-10-08 11:59 ` Joy Chakraborty
2024-10-08 12:10 ` Krzysztof Kozlowski
2024-10-08 12:40 ` Joy Chakraborty
2024-10-08 12:59 ` Krzysztof Kozlowski
2024-10-07 13:55 ` [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 De-emphasis Joy Chakraborty
2024-10-07 13:55 ` [PATCH 2/2] usb: dwc3: Program USB Gen2 de-emphasis defined in PIPE4 spec Joy Chakraborty
2024-10-07 13:55 ` [PATCH 2/2] usb: dwc3: Program USB Gen2 De-emphasis " Joy Chakraborty
2024-10-16 8:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101635-clergyman-dyslexia-9c75@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joychakr@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.