All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Daniel Scally <dan.scally@ideasonboard.com>,
	Avichal Rakesh <arakesh@google.com>,
	Jayant Chowdhary <jchowdhary@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v6 0/9] usb: gadget: uvc: effectively fill the udc isoc pipeline with available video buffers and fixes
Date: Wed, 16 Oct 2024 10:47:00 +0200	[thread overview]
Message-ID: <2024101636-studied-job-41b2@gregkh> (raw)
In-Reply-To: <20240403-uvc_request_length_by_interval-v6-0-08c05522e1f5@pengutronix.de>

On Sun, Sep 29, 2024 at 08:59:20PM +0200, Michael Grzeschik wrote:
> This patch series is improving the size calculation and allocation of
> the uvc requests. Using the selected frame duration of the stream it is
> possible to calculate the number of requests based on the interval
> length.
> 
> It also precalculates the request length based on the actual per frame
> size for compressed formats.
> 
> For this calculations to work it was needed to rework the request
> queueing by moving the encoding to one extra thread (in this case we
> chose the qbuf) context.
> 
> Next it was needed to move the actual request enqueueing to one extra
> thread which is kept busy to fill the isoc queue in the udc.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> Changes in v6:
> - fixes in: ("usb: gadget: uvc: add trace of enqueued and completed requests")
> - Link to v5: https://lore.kernel.org/r/20240403-uvc_request_length_by_interval-v5-0-2de78794365c@pengutronix.de

Breaks the build for me:

In file included from drivers/usb/gadget/function/uvc_trace.h:60,
                 from drivers/usb/gadget/function/uvc_trace.c:11:
./include/trace/define_trace.h:95:42: fatal error: ./uvc_trace.h: No such file or directory
   95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
      |                                          ^

what did you build this against?

thanks,

greg k-h

  parent reply	other threads:[~2024-10-16  8:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29 18:59 [PATCH v6 0/9] usb: gadget: uvc: effectively fill the udc isoc pipeline with available video buffers and fixes Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 1/9] usb: gadget: uvc: wake pump everytime we update the free list Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 2/9] usb: gadget: uvc: only enqueue zero length requests in potential underrun Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 3/9] usb: gadget: uvc: rework to enqueue in pump worker from encoded queue Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 4/9] usb: gadget: uvc: add g_parm and s_parm for frame interval Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 5/9] usb: gadget: uvc: set req_size and n_requests based on the " Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 6/9] usb: gadget: uvc: set req_length based on payload by nreqs instead of req_size Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 7/9] usb: gadget: uvc: set nbuffers to minimum STREAMING_MIN_BUFFERS in uvc_queue_setup Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 8/9] usb: gadget: uvc: add trace of enqueued and completed requests Michael Grzeschik
2024-09-29 18:59 ` [PATCH v6 9/9] usb: gadget: uvc: dont call usb_composite_setup_continue when not streaming Michael Grzeschik
2024-10-16  8:47 ` Greg Kroah-Hartman [this message]
2024-10-16 14:00   ` [PATCH v6 0/9] usb: gadget: uvc: effectively fill the udc isoc pipeline with available video buffers and fixes Michael Grzeschik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024101636-studied-job-41b2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arakesh@google.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=jchowdhary@google.com \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.