From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Remove unneeded semicolon.
Date: Wed, 16 Oct 2024 09:23:41 +0200 [thread overview]
Message-ID: <2024101657-osmosis-fading-4380@gregkh> (raw)
In-Reply-To: <20241016071941.1615135-1-roheetchavan@gmail.com>
On Wed, Oct 16, 2024 at 12:49:41PM +0530, Rohit Chavan wrote:
> This patch cleans up the GPIB driver code by removing
> unneeded semicolons.
Nit, you can use all 72 columns.
>
> Files modified:
> drivers/staging/gpib/tms9914/tms9914.c
> drivers/staging/gpib/tnt4882/mite.c
Why are these lines needed? We know what files are modified by looking
at the diff :)
Please fix up and send a v2.
thanks,
greg k-
prev parent reply other threads:[~2024-10-16 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 7:19 [PATCH] staging: gpib: Remove unneeded semicolon Rohit Chavan
2024-10-16 7:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101657-osmosis-fading-4380@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=roheetchavan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.