All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Aniket Limaye <a-limaye@ti.com>
Cc: <u-boot@lists.denx.de>, <trini@konsulko.com>, <u-kumar1@ti.com>,
	<reidt@ti.com>, <m-chawdhry@ti.com>, <nm@ti.com>
Subject: Re: [PATCH 6/6] DONOTMERGE: For testing only
Date: Thu, 17 Oct 2024 09:22:27 +0200	[thread overview]
Message-ID: <20241017092227.724ad2cf@karo-electronics.de> (raw)
In-Reply-To: <20241017062911.2241167-7-a-limaye@ti.com>

Hi,

On Thu, 17 Oct 2024 11:59:13 +0530 Aniket Limaye wrote:
> From: Reid Tonking <reidt@ti.com>
> 
> This just provides some useful print outs and the proper config to
> test the functionality. For J7200 boards that do not have efuse
> burned in, the hardcoded 760000 is needed in the vd_data, since
> it would be populated otherwise
> 
> Signed-off-by: Reid Tonking <reidt@ti.com>
> Signed-off-by: Aniket Limaye <a-limaye@ti.com>
> ---
>  arch/arm/mach-k3/j721e/j721e_init.c | 9 +++++++++
>  configs/j7200_evm_r5_defconfig      | 2 +-
>  drivers/misc/k3_avs.c               | 4 +++-
>  3 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-k3/j721e/j721e_init.c b/arch/arm/mach-k3/j721e/j721e_init.c
> index 0620759c36c..19865f7dd40 100644
> --- a/arch/arm/mach-k3/j721e/j721e_init.c
> +++ b/arch/arm/mach-k3/j721e/j721e_init.c
> @@ -152,6 +152,8 @@ int fix_freq(const void *fdt)
>  {
>  		int node, ret;
>  		u32 opp_low_freq[3];
> +		int len;
> +		const u32 *reg;
>  
>  		node = fdt_node_offset_by_compatible(fdt, -1, "ti,am654-rproc");
>  			if (node < 0) {
> @@ -159,6 +161,11 @@ int fix_freq(const void *fdt)
>  				return node;
>  			}
>  
> +		/* check freqs */
> +		reg = fdt_getprop(fdt, node, "assigned-clock-rates", &len);
> +		printf("OPP_NOM: arm_clk:%d | gtc_clk:%d | msmc_clk:%d\n",
> +				fdt32_to_cpu(reg[0]), fdt32_to_cpu(reg[1]), fdt32_to_cpu(reg[2]));
> +
>  		/* j7200 opp low values according to data sheet */
>  		opp_low_freq[0] = cpu_to_fdt32(1000000000); /* 202-2 -> A72SS0_CORE0_0_ARM_CLK */
>  		opp_low_freq[1] = cpu_to_fdt32(200000000); /* 61-1 -> GTC0_GTC_CLK */
> @@ -170,6 +177,8 @@ int fix_freq(const void *fdt)
>  				printf("%s: Can not set value\n", __func__);
>  				return ret;
>  			}
> +		printf("OPP_LOW: arm_clk:%d | gtc_clk:%d | msmc_clk:%d\n",
> +				fdt32_to_cpu(opp_low_freq[0]), fdt32_to_cpu(opp_low_freq[1]), fdt32_to_cpu(opp_low_freq[2]));
>  
>  		return 0;
>  }
> diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig
> index 7d43d8d702a..6fdf34c9644 100644
> --- a/configs/j7200_evm_r5_defconfig
> +++ b/configs/j7200_evm_r5_defconfig
> @@ -103,7 +103,7 @@ CONFIG_K3_SEC_PROXY=y
>  CONFIG_FS_LOADER=y
>  CONFIG_SPL_FS_LOADER=y
>  CONFIG_K3_AVS0=y
> -# CONFIG_K3_OPP_LOW is not set
> +CONFIG_K3_OPP_LOW=y
>  CONFIG_SUPPORT_EMMC_BOOT=y
>  CONFIG_SPL_MMC_HS400_SUPPORT=y
>  CONFIG_MMC_SDHCI=y
> diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c
> index 932b355a5c1..e93aa267d51 100644
> --- a/drivers/misc/k3_avs.c
> +++ b/drivers/misc/k3_avs.c
> @@ -121,6 +121,8 @@ static int k3_avs_program_voltage(struct k3_avs_privdata *priv,
>  	if (!vd->supply)
>  		return -ENODEV;
>  
> +  printf("Program voltage: opp_id:%d | opp_volt:%d\n", opp_id, volt);
> +
buggy indentation.


Lothar Waßmann

  reply	other threads:[~2024-10-17  7:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  6:29 [PATCH 0/6] Add OPP_LOW support for J7200 Aniket Limaye
2024-10-17  6:29 ` [PATCH 1/6] arm: dts: k3-j7200-r5-common: Add msmc clk to a72 node Aniket Limaye
2024-10-17 10:30   ` Neha Malcom Francis
2024-10-23  6:12     ` Aniket Limaye
2024-10-23  6:47       ` Neha Malcom Francis
2024-10-23  7:58         ` Aniket Limaye
2024-10-23  8:51           ` Neha Malcom Francis
2024-10-17  6:29 ` [PATCH 2/6] misc: k3_avs: Add OPP_LOW voltage and frequency to vd_data Aniket Limaye
2024-10-17  6:29 ` [PATCH 3/6] misc: k3_avs: Add k3_check_opp function Aniket Limaye
2024-10-17 10:36   ` Neha Malcom Francis
2024-10-22 12:55     ` Limaye, Aniket
2024-10-17  6:29 ` [PATCH 4/6] arm: mach-k3: j721e-init.c: J7200: Add support for CONFIG_K3_OPP_LOW Aniket Limaye
2024-10-17 10:40   ` Neha Malcom Francis
2024-10-22 12:57     ` Limaye, Aniket
2024-10-17  6:29 ` [PATCH 5/6] configs: j7200_evm_r5_defconfig: Define K3_OPP_LOW Aniket Limaye
2024-10-17  6:29 ` [PATCH 6/6] DONOTMERGE: For testing only Aniket Limaye
2024-10-17  7:22   ` Lothar Waßmann [this message]
2024-10-17 17:54   ` Tom Rini
2024-10-18  4:51     ` Aniket Limaye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017092227.724ad2cf@karo-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=a-limaye@ti.com \
    --cc=m-chawdhry@ti.com \
    --cc=nm@ti.com \
    --cc=reidt@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.