From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v4 3/8] gpio: cdev: go back to storing debounce period in the GPIO descriptor
Date: Thu, 17 Oct 2024 20:44:18 +0800 [thread overview]
Message-ID: <20241017124418.GA221864@rigel> (raw)
In-Reply-To: <20241017-gpio-notify-in-kernel-events-v4-3-64bc05f3be0c@linaro.org>
On Thu, Oct 17, 2024 at 10:14:11AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> @@ -1047,7 +925,7 @@ static int debounce_setup(struct line *line, unsigned int debounce_period_us)
> /* try hardware */
> ret = gpiod_set_debounce(line->desc, debounce_period_us);
> if (!ret) {
> - line_set_debounce_period(line, debounce_period_us);
> + WRITE_ONCE(line->desc->debounce_period_us, debounce_period_us);
> return ret;
> }
Not related to this change, but this check looks redundant to me - the same
is performed where debounce_setup() is called.
Want a patch to remove it?
Cheers,
Kent.
next prev parent reply other threads:[~2024-10-17 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 8:14 [PATCH v4 0/8] gpio: notify user-space about config changes in the kernel Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 1/8] gpiolib: notify user-space when a driver requests its own desc Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 2/8] gpiolib: unduplicate chip guard in set_config path Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 3/8] gpio: cdev: go back to storing debounce period in the GPIO descriptor Bartosz Golaszewski
2024-10-17 12:44 ` Kent Gibson [this message]
2024-10-17 14:13 ` Bartosz Golaszewski
2024-10-17 14:16 ` Kent Gibson
2024-10-17 14:43 ` Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 4/8] gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 5/8] gpiolib: add a per-gpio_device line state notification workqueue Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 6/8] gpio: cdev: put emitting the line state events on a workqueue Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 7/8] gpiolib: switch the line state notifier to atomic Bartosz Golaszewski
2024-10-17 8:14 ` [PATCH v4 8/8] gpiolib: notify user-space about in-kernel line state changes Bartosz Golaszewski
2024-10-17 12:53 ` Kent Gibson
2024-10-17 14:14 ` Bartosz Golaszewski
2024-10-17 14:20 ` Kent Gibson
2024-10-17 14:25 ` Kent Gibson
2024-10-17 14:59 ` Bartosz Golaszewski
2024-10-17 15:02 ` Kent Gibson
2024-10-17 15:04 ` Bartosz Golaszewski
2024-10-17 15:12 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017124418.GA221864@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.