All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Peter Rashleigh <peter@rashleigh.ca>
Cc: andrew@lunn.ch, netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH RESEND net] net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x
Date: Thu, 17 Oct 2024 15:36:27 +0100	[thread overview]
Message-ID: <20241017143627.GT1697@kernel.org> (raw)
In-Reply-To: <20241016040822.3917-1-peter@rashleigh.ca>

On Tue, Oct 15, 2024 at 09:08:22PM -0700, Peter Rashleigh wrote:
> mv88e6393x_port_set_policy doesn't correctly shift the ptr value when
> converting the policy format between the old and new styles, so the 
> target register ends up with the ptr being written over the data bits.
> 
> Shift the pointer to align with the format expected by 
> mv88e6393x_port_policy_write().
> 
> Fixes: 6584b26020fc ("net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst")
> Signed-off-by: Peter Rashleigh <peter@rashleigh.ca>

Thanks, I agree with your analysis.
And that the problem was introduced by the cited commit.

Reviewed-by: Simon Horman <horms@kernel.org>

...

  reply	other threads:[~2024-10-17 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  4:08 [PATCH RESEND net] net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x Peter Rashleigh
2024-10-17 14:36 ` Simon Horman [this message]
2024-10-20 14:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017143627.GT1697@kernel.org \
    --to=horms@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter@rashleigh.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.