From: Stephen Hemminger <stephen@networkplumber.org>
To: Long Li <longli@microsoft.com>
Cc: "longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues
Date: Thu, 17 Oct 2024 16:02:39 -0700 [thread overview]
Message-ID: <20241017160239.1fbd09a4@hermes.local> (raw)
In-Reply-To: <CYYPR21MB4022FF65F134D7498DD8C7A4CE472@CYYPR21MB4022.namprd21.prod.outlook.com>
On Thu, 17 Oct 2024 22:38:49 +0000
Long Li <longli@microsoft.com> wrote:
> > Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues
> >
> > On Thu, 17 Oct 2024 12:20:29 -0700
> > longli@linuxonhyperv.com wrote:
> >
> > > +static void
> > > +hn_rx_queue_free_common(struct hn_rx_queue *rxq) {
> > > + if (!rxq)
> > > + return;
> > > +
> > > + rte_free(rxq->rxbuf_info);
> > > + rte_free(rxq->event_buf);
> > > + rte_free(rxq);
> > > +}
> >
> > Minor nit, DPDK style is for the bracket on the next line.
> > Checkpatch will complain about this.
>
> Is it okay to take the patch as is, or should I send a v6 to have it fixed?
It is ok as is, but followup to fix the minor stuff like this would be good.
next prev parent reply other threads:[~2024-10-17 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 19:20 [Patch v5] net/netvsc: fix number Tx queues > Rx queues longli
2024-10-17 22:34 ` Stephen Hemminger
2024-10-17 22:38 ` Long Li
2024-10-17 23:02 ` Stephen Hemminger [this message]
2024-10-18 0:04 ` Ferruh Yigit
2024-10-17 23:03 ` Ferruh Yigit
2024-10-18 0:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017160239.1fbd09a4@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.