From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
devicetree@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n
Date: Thu, 17 Oct 2024 15:38:10 -0500 [thread overview]
Message-ID: <20241017203810.GA814469-robh@kernel.org> (raw)
In-Reply-To: <20241016212016.887552-1-sboyd@kernel.org>
On Wed, Oct 16, 2024 at 02:20:15PM -0700, Stephen Boyd wrote:
> Some configurations want to enable CONFIG_KUNIT without enabling
> CONFIG_OF_OVERLAY. The kunit overlay code already skips if
> CONFIG_OF_OVERLAY isn't enabled, so this select here isn't really doing
> anything besides making it easier to run the tests without them
> skipping. Remove the select and move the config setting to the
> drivers/of/.kunitconfig file so that the overlay tests can be run with
> or without CONFIG_OF_OVERLAY set to test either behavior.
>
> Fixes: 5c9dd72d8385 ("of: Add a KUnit test for overlays and test managed APIs")
Doesn't really seem like a fix. Does this need to go into 6.12?
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
> drivers/of/.kunitconfig | 1 +
> drivers/of/Kconfig | 1 -
> drivers/of/overlay_test.c | 2 ++
> 3 files changed, 3 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2024-10-17 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 21:20 [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n Stephen Boyd
2024-10-17 20:38 ` Rob Herring [this message]
2024-10-18 22:21 ` Stephen Boyd
2024-11-08 8:56 ` Geert Uytterhoeven
2024-11-08 16:55 ` Rob Herring
2024-11-12 19:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017203810.GA814469-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.