From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
oss-drivers <oss-drivers@corigine.com>,
"Long Wu" <Long.Wu@nephogine.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v2] examples/l3fwd: support setting the data size of mbuf
Date: Thu, 17 Oct 2024 20:42:06 -0700 [thread overview]
Message-ID: <20241017204206.2dc20546@hermes.local> (raw)
In-Reply-To: <SJ0PR13MB5545847BC6D37F95822D96759E402@SJ0PR13MB5545.namprd13.prod.outlook.com>
On Fri, 18 Oct 2024 03:21:28 +0000
Chaoyong He <chaoyong.he@corigine.com> wrote:
> > RTE_PKTMBUF_HEADROOM); }
> > > +
> >
> > Not sure why this is needed? What is the problem with the original code?
> > Are you trying to force packets to be segmented?
>
> Actually, we are trying to force packets *not* segmented by making the mbuf size large enough to hold the packets.
>
> In our user case, we start l3fwd app with parameter '--max-pkt-len 4000', and obviously the original logic with RTE_MBUF_DEFAULT_DATAROOM mbuf size will cause the packets to be segmented.
> Which is not what we want, so we add this new '--mbuf-size=4096' parameter, the mbuf size will large enough to hold even the largest packet.
>
> Do you think this make sense?
Maybe query the driver, and use the max_rx_pkt_len as input to deciding the right mbuf size.
If max-pkt-len was 4000 and driver can only take 2K buffers, then use 2K mbuf size.
If max-pkt-len was 1500 then use mtu + headroom and round up
next prev parent reply other threads:[~2024-10-18 3:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 8:22 [PATCH] examples/l3fwd: support setting the data size of mbuf Chaoyong He
2024-10-16 9:05 ` Morten Brørup
2024-10-16 15:02 ` Stephen Hemminger
2024-10-16 21:17 ` Patrick Robb
2024-10-17 19:12 ` Stephen Hemminger
2024-10-18 2:42 ` [PATCH v2] " Chaoyong He
2024-10-18 2:50 ` lihuisong (C)
2024-10-18 2:59 ` Stephen Hemminger
2024-10-18 3:21 ` Chaoyong He
2024-10-18 3:42 ` Stephen Hemminger [this message]
2024-10-18 5:50 ` Chaoyong He
2024-10-18 15:59 ` Stephen Hemminger
2024-10-21 2:00 ` Chaoyong He
2024-10-21 17:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017204206.2dc20546@hermes.local \
--to=stephen@networkplumber.org \
--cc=Long.Wu@nephogine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.