From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] nvme: enhance cns version checking
Date: Fri, 18 Oct 2024 07:12:01 +0200 [thread overview]
Message-ID: <20241018051201.GD19831@lst.de> (raw)
In-Reply-To: <20241017181231.2937468-1-kbusch@meta.com>
On Thu, Oct 17, 2024 at 11:12:31AM -0700, Keith Busch wrote:
> + if (ctrl->vs >= NVME_VS(1, 1, 0) &&
> + (!(ctrl->quirks & NVME_QUIRK_IDENTIFY_CNS)))
No need for the braces around the ngation here.
> + return cns <= 3;
> +
> + /*
> + * NVMe 1.0 used a single bit for the CNS value.
> + */
> + return cns <= 1;
Slightly messed up indentation.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-18 5:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 18:12 [PATCHv2] nvme: enhance cns version checking Keith Busch
2024-10-18 5:12 ` Christoph Hellwig [this message]
2024-10-21 0:20 ` Sagi Grimberg
2024-10-22 16:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018051201.GD19831@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.