From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: "Hellwig, Christoph" <hch@infradead.org>
Cc: Laurence Oberman <loberman@redhat.com>, Xiao Ni <xni@redhat.com>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH] Add the ":" to the allowed_symbols list to work with the latest POSIX changes
Date: Fri, 18 Oct 2024 08:28:19 +0200 [thread overview]
Message-ID: <20241018082819.00001d0f@linux.intel.com> (raw)
In-Reply-To: <ZxEtxXTLZVgP-_kJ@infradead.org>
On Thu, 17 Oct 2024 08:31:17 -0700
"Hellwig, Christoph" <hch@infradead.org> wrote:
> On Thu, Oct 17, 2024 at 11:27:24AM -0400, Laurence Oberman wrote:
> > I re-ran all the tests in house and I can actually start the arrays
> > that have the ":" in the names, just not create new ones. So I think we
> > leave this as is and we keep the adherence to POSIX for newly created
> > arrays only.
>
> Can we please stop talking about Posix compliance here?
>
> The POSIX Portable Character Set is the minimum set of characters that
> need to be supported in each character set for Posix compliance.
>
> Including other characters is perfectly Posix complain, just not fully
> portable.
>
Right, good one. I named it just POSIX for simplicity and now we are abusing
it.
Cool, the main reasons ":" is excluded is special meaning for native metadata
and I still think it is right change. They can use --homehost option if they
want to customize it, it should be perfectly valid:
# mdadm -CR vol0 --homehost myhost -l0 -n2 /dev/nvme[45]n1 -z5G --assume-clean
# mdadm -E /dev/nvme4n1 | grep Name
Name : myhost:vol0
Isn't result the same?
I still need to look into assemble issue to understand why it is not working.
Maybe there is small functional difference I'm not familiar with.
Thanks,
Mariusz
next prev parent reply other threads:[~2024-10-18 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 17:35 [PATCH] Add the ":" to the allowed_symbols list to work with the latest POSIX changes Laurence Oberman
2024-10-15 17:41 ` Nigel Croxon
2024-10-16 3:59 ` Christoph Hellwig
2024-10-16 7:50 ` Mariusz Tkaczyk
2024-10-16 7:53 ` Christoph Hellwig
2024-10-16 8:14 ` Mariusz Tkaczyk
2024-10-16 13:10 ` Laurence Oberman
2024-10-17 9:24 ` Xiao Ni
2024-10-17 11:26 ` Mariusz Tkaczyk
2024-10-17 12:23 ` Laurence Oberman
2024-10-17 15:27 ` Laurence Oberman
2024-10-17 15:31 ` Hellwig, Christoph
2024-10-18 6:28 ` Mariusz Tkaczyk [this message]
2024-10-17 15:04 ` Hellwig, Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018082819.00001d0f@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.