From: Simon Horman <horms@kernel.org>
To: Ales Nezbeda <anezbeda@redhat.com>
Cc: netdev@vger.kernel.org, sd@queasysnail.net, kuba@kernel.org
Subject: Re: [PATCH net-next v2] netdevsim: macsec: pad u64 to correct length in logs
Date: Fri, 18 Oct 2024 09:56:17 +0100 [thread overview]
Message-ID: <20241018085617.GB1697@kernel.org> (raw)
In-Reply-To: <20241017131933.136971-1-anezbeda@redhat.com>
On Thu, Oct 17, 2024 at 03:19:33PM +0200, Ales Nezbeda wrote:
> Commit 02b34d03a24b ("netdevsim: add dummy macsec offload") pads u64
> number to 8 characters using "%08llx" format specifier.
>
> Changing format specifier to "%016llx" ensures that no matter the value
> the representation of number in log is always the same length.
>
> Before this patch, entry in log for value '1' would say:
> removing SecY with SCI 00000001 at index 2
> After this patch is applied, entry in log will say:
> removing SecY with SCI 0000000000000001 at index 2
>
> Signed-off-by: Ales Nezbeda <anezbeda@redhat.com>
> ---
> v2
> - Remove fixes tag and post against net-next
> - v1 ref: https://lore.kernel.org/netdev/20241015110943.94217-1-anezbeda@redhat.com/
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-18 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 13:19 [PATCH net-next v2] netdevsim: macsec: pad u64 to correct length in logs Ales Nezbeda
2024-10-18 8:56 ` Simon Horman [this message]
2024-10-18 9:13 ` Sabrina Dubroca
2024-10-23 8:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018085617.GB1697@kernel.org \
--to=horms@kernel.org \
--cc=anezbeda@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.