Re: [RFC PATCH v2 1/1] exec: seal system mappings

[kernel test robot <lkp@intel.com>]

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on brauner-vfs/vfs.all perf-tools-next/perf-tools-next tip/perf/core perf-tools/perf-tools linus/master v6.12-rc3 next-20241017]
[cannot apply to kees/for-next/execve kees/for-next/pstore kees/for-next/kspp tip/x86/asm acme/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jeffxu-chromium-org/exec-seal-system-mappings/20241015-055145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241014215022.68530-2-jeffxu%40google.com
patch subject: [RFC PATCH v2 1/1] exec: seal system mappings
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20241018/202410181124.TWvcRfi7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410181124.TWvcRfi7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410181124.TWvcRfi7-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/events/uprobes.c: In function 'xol_add_vma':
>> kernel/events/uprobes.c:1507:70: error: 'VM_SEALED' undeclared (first use in this function); did you mean 'VM_SHARED'?
    1507 |                                 VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED,
         |                                                                      ^~~~~~~~~
         |                                                                      VM_SHARED
   kernel/events/uprobes.c:1507:70: note: each undeclared identifier is reported only once for each function it appears in

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +1507 kernel/events/uprobes.c

  1481	
  1482	/* Slot allocation for XOL */
  1483	static int xol_add_vma(struct mm_struct *mm, struct xol_area *area)
  1484	{
  1485		struct vm_area_struct *vma;
  1486		int ret;
  1487	
  1488		if (mmap_write_lock_killable(mm))
  1489			return -EINTR;
  1490	
  1491		if (mm->uprobes_state.xol_area) {
  1492			ret = -EALREADY;
  1493			goto fail;
  1494		}
  1495	
  1496		if (!area->vaddr) {
  1497			/* Try to map as high as possible, this is only a hint. */
  1498			area->vaddr = get_unmapped_area(NULL, TASK_SIZE - PAGE_SIZE,
  1499							PAGE_SIZE, 0, 0);
  1500			if (IS_ERR_VALUE(area->vaddr)) {
  1501				ret = area->vaddr;
  1502				goto fail;
  1503			}
  1504		}
  1505	
  1506		vma = _install_special_mapping(mm, area->vaddr, PAGE_SIZE,
> 1507					VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED,
  1508					&xol_mapping);
  1509		if (IS_ERR(vma)) {
  1510			ret = PTR_ERR(vma);
  1511			goto fail;
  1512		}
  1513	
  1514		ret = 0;
  1515		/* pairs with get_xol_area() */
  1516		smp_store_release(&mm->uprobes_state.xol_area, area); /* ^^^ */
  1517	 fail:
  1518		mmap_write_unlock(mm);
  1519	
  1520		return ret;
  1521	}
  1522	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki