From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, <linux-s390@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/3] PCI: Remove unused PCI_SUBTRACTIVE_DECODE
Date: Fri, 18 Oct 2024 16:58:42 +0100 [thread overview]
Message-ID: <20241018165842.0000597d@Huawei.com> (raw)
In-Reply-To: <20241017141111.44612-1-ilpo.jarvinen@linux.intel.com>
On Thu, 17 Oct 2024 17:11:08 +0300
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> The commit 2fe2abf896c1 ("PCI: augment bus resource table with a list")
> added PCI_SUBTRACTIVE_DECODE which is put into the struct
> pci_bus_resource flags field but is never read. There seems to never
> have been users for it. Remove both PCI_SUBTRACTIVE_DECODE and the
> flags field from the struct pci_bus_resource.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Nice cleanup.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> arch/s390/pci/pci_bus.c | 2 +-
> arch/x86/pci/fixup.c | 2 +-
> drivers/pci/bus.c | 4 +---
> drivers/pci/probe.c | 5 ++---
> include/linux/pci.h | 12 +-----------
> 5 files changed, 6 insertions(+), 19 deletions(-)
next prev parent reply other threads:[~2024-10-18 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 14:11 [PATCH 1/3] PCI: Remove unused PCI_SUBTRACTIVE_DECODE Ilpo Järvinen
2024-10-17 14:11 ` [PATCH 2/3] PCI: Move struct pci_bus_resource into bus.c Ilpo Järvinen
2024-10-18 16:00 ` Jonathan Cameron
2024-10-17 14:11 ` [PATCH 3/3] PCI: Use reverse logic in pci_read_bridge_bases() Ilpo Järvinen
2024-10-18 16:07 ` Jonathan Cameron
2024-10-18 15:58 ` Jonathan Cameron [this message]
2024-10-18 18:36 ` [PATCH 1/3] PCI: Remove unused PCI_SUBTRACTIVE_DECODE Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018165842.0000597d@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=agordeev@linux.ibm.com \
--cc=bhelgaas@google.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.