From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v2 3/4] drm/xe: Move suballocator init to after display init
Date: Fri, 18 Oct 2024 19:06:30 +0200 [thread overview]
Message-ID: <20241018170631.6598-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241018170631.6598-1-maarten.lankhorst@linux.intel.com>
No allocations should be done before we have had a chance to preserve
the display fb.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 6 ++++++
drivers/gpu/drm/xe/xe_tile.c | 12 ++++++++----
drivers/gpu/drm/xe/xe_tile.h | 1 +
3 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 51bb9d875268f..76d8c6868d15e 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -736,6 +736,12 @@ int xe_device_probe(struct xe_device *xe)
if (err)
goto err;
+ for_each_tile(tile, xe, id) {
+ err = xe_tile_init(tile);
+ if (err)
+ goto err;
+ }
+
for_each_gt(gt, xe, id) {
last_gt = id;
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 07cf7cfe4abd5..2825553b568f7 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -170,10 +170,6 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
if (err)
return err;
- tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
- if (IS_ERR(tile->mem.kernel_bb_pool))
- return PTR_ERR(tile->mem.kernel_bb_pool);
-
xe_wa_apply_tile_workarounds(tile);
err = xe_tile_sysfs_init(tile);
@@ -181,6 +177,14 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
return 0;
}
+int xe_tile_init(struct xe_tile *tile)
+{
+ tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
+ if (IS_ERR(tile->mem.kernel_bb_pool))
+ return PTR_ERR(tile->mem.kernel_bb_pool);
+
+ return 0;
+}
void xe_tile_migrate_wait(struct xe_tile *tile)
{
xe_migrate_wait(tile->migrate);
diff --git a/drivers/gpu/drm/xe/xe_tile.h b/drivers/gpu/drm/xe/xe_tile.h
index 1c9e42ade6b05..eb939316d55b0 100644
--- a/drivers/gpu/drm/xe/xe_tile.h
+++ b/drivers/gpu/drm/xe/xe_tile.h
@@ -12,6 +12,7 @@ struct xe_tile;
int xe_tile_init_early(struct xe_tile *tile, struct xe_device *xe, u8 id);
int xe_tile_init_noalloc(struct xe_tile *tile);
+int xe_tile_init(struct xe_tile *tile);
void xe_tile_migrate_wait(struct xe_tile *tile);
--
2.45.2
next prev parent reply other threads:[~2024-10-18 17:06 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 17:06 [CI v2 0/4] (CI) drm/xe: Fix initial framebuffer handover Maarten Lankhorst
2024-10-18 17:06 ` [CI v2 1/4] drm/xe: Remove double pageflip Maarten Lankhorst
2024-10-18 17:12 ` Lucas De Marchi
2024-10-18 17:06 ` [CI v2 2/4] drm/i915/display: Use async flip when available for initial plane config Maarten Lankhorst
2024-10-18 17:14 ` Lucas De Marchi
2024-10-18 17:06 ` Maarten Lankhorst [this message]
2024-10-18 17:30 ` [CI v2 3/4] drm/xe: Move suballocator init to after display init Lucas De Marchi
2024-10-18 17:06 ` [CI v2 4/4] drm/xe: Initialise display before GT and tile init Maarten Lankhorst
2024-10-18 17:40 ` Lucas De Marchi
2024-10-18 20:05 ` [CI v2.2] " Maarten Lankhorst
2024-10-21 10:38 ` [CI v2.3] " Maarten Lankhorst
2024-10-24 13:46 ` [PATCH] " Maarten Lankhorst
2024-10-24 15:15 ` Maarten Lankhorst
2024-10-25 10:14 ` Maarten Lankhorst
2024-10-25 13:04 ` Maarten Lankhorst
2024-10-18 18:08 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover Patchwork
2024-10-18 18:08 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-18 18:10 ` ✓ CI.KUnit: success " Patchwork
2024-10-18 18:21 ` ✓ CI.Build: " Patchwork
2024-10-18 18:23 ` ✓ CI.Hooks: " Patchwork
2024-10-18 18:25 ` ✗ CI.checksparse: warning " Patchwork
2024-10-18 18:45 ` ✗ CI.BAT: failure " Patchwork
2024-10-18 21:25 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev2) Patchwork
2024-10-18 21:25 ` ✓ CI.checkpatch: " Patchwork
2024-10-18 21:27 ` ✓ CI.KUnit: " Patchwork
2024-10-18 21:38 ` ✓ CI.Build: " Patchwork
2024-10-18 21:40 ` ✓ CI.Hooks: " Patchwork
2024-10-18 21:42 ` ✗ CI.checksparse: warning " Patchwork
2024-10-18 22:04 ` ✗ CI.BAT: failure " Patchwork
2024-10-19 11:17 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover Patchwork
2024-10-19 14:41 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev2) Patchwork
2024-10-21 10:50 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev3) Patchwork
2024-10-21 10:50 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 10:52 ` ✓ CI.KUnit: " Patchwork
2024-10-21 11:03 ` ✓ CI.Build: " Patchwork
2024-10-21 11:06 ` ✓ CI.Hooks: " Patchwork
2024-10-21 11:07 ` ✗ CI.checksparse: warning " Patchwork
2024-10-21 11:36 ` ✓ CI.BAT: success " Patchwork
2024-10-21 15:59 ` ✗ CI.FULL: failure " Patchwork
2024-10-25 1:30 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev5) Patchwork
2024-10-25 1:30 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 1:31 ` ✗ CI.KUnit: failure " Patchwork
2024-10-25 11:29 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev6) Patchwork
2024-10-25 11:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 11:30 ` ✓ CI.KUnit: success " Patchwork
2024-10-25 11:42 ` ✓ CI.Build: " Patchwork
2024-10-25 11:44 ` ✓ CI.Hooks: " Patchwork
2024-10-25 11:46 ` ✗ CI.checksparse: warning " Patchwork
2024-10-25 12:14 ` ✗ CI.BAT: failure " Patchwork
2024-10-25 13:11 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev7) Patchwork
2024-10-25 13:11 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 13:13 ` ✓ CI.KUnit: success " Patchwork
2024-10-25 13:24 ` ✓ CI.Build: " Patchwork
2024-10-25 13:27 ` ✓ CI.Hooks: " Patchwork
2024-10-25 13:28 ` ✗ CI.checksparse: warning " Patchwork
2024-10-25 13:54 ` ✗ CI.BAT: failure " Patchwork
2024-10-26 23:39 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev6) Patchwork
2024-10-27 1:46 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev7) Patchwork
2024-10-29 11:40 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018170631.6598-4-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.