From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Furong Xu <0x1207@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
xfr@outlook.com
Subject: Re: [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ
Date: Fri, 18 Oct 2024 20:16:03 +0100 [thread overview]
Message-ID: <20241018191603.GA1697@kernel.org> (raw)
In-Reply-To: <20241017171852.fwomny3wedypybhx@skbuf>
On Thu, Oct 17, 2024 at 08:18:52PM +0300, Vladimir Oltean wrote:
> On Tue, Oct 15, 2024 at 05:09:25PM +0800, Furong Xu wrote:
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > index 917796293c26..c66fa6040672 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > @@ -84,8 +84,8 @@
> > #define XGMAC_MCBCQEN BIT(15)
> > #define XGMAC_MCBCQ GENMASK(11, 8)
> > #define XGMAC_MCBCQ_SHIFT 8
> > -#define XGMAC_RQ GENMASK(7, 4)
> > -#define XGMAC_RQ_SHIFT 4
> > +#define XGMAC_FPRQ GENMASK(7, 4)
> > +#define XGMAC_FPRQ_SHIFT 4
>
> If you made use of FIELD_PREP(), you would not need the _SHIFT variant at all
> (though that would be a separate logical change).
+1
> > #define XGMAC_UPQ GENMASK(3, 0)
> > #define XGMAC_UPQ_SHIFT 0
> > #define XGMAC_RXQ_CTRL2 0x000000a8
>
next prev parent reply other threads:[~2024-10-18 19:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 9:09 [PATCH net-next v1 0/5] net: stmmac: Refactor FPE as a separate module Furong Xu
2024-10-15 9:09 ` [PATCH net-next v1 1/5] net: stmmac: Introduce separate files for FPE implementation Furong Xu
2024-10-17 12:39 ` Simon Horman
2024-10-15 9:09 ` [PATCH net-next v1 2/5] net: stmmac: Introduce stmmac_fpe_ops for gmac4 and xgmac Furong Xu
2024-10-17 12:39 ` Simon Horman
2024-10-15 9:09 ` [PATCH net-next v1 3/5] net: stmmac: Rework marco definitions " Furong Xu
2024-10-17 12:39 ` Simon Horman
2024-10-17 17:16 ` Vladimir Oltean
2024-10-15 9:09 ` [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ Furong Xu
2024-10-17 12:40 ` Simon Horman
2024-10-17 12:41 ` Simon Horman
2024-10-17 17:18 ` Vladimir Oltean
2024-10-18 19:16 ` Simon Horman [this message]
2024-10-15 9:09 ` [PATCH net-next v1 5/5] net: stmmac: xgmac: Complete FPE support Furong Xu
2024-10-17 12:29 ` Simon Horman
2024-10-17 17:31 ` Vladimir Oltean
2024-10-17 17:06 ` [PATCH net-next v1 0/5] net: stmmac: Refactor FPE as a separate module Vladimir Oltean
2024-10-18 1:33 ` Furong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018191603.GA1697@kernel.org \
--to=horms@kernel.org \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.