From: Stephen Hemminger <stephen@networkplumber.org>
To: longli@linuxonhyperv.com
Cc: longli@microsoft.com, Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, "Hui (Hui) Ling" <hling@SonicWall.com>,
Wei Hu <weh@microsoft.com>,
stable@dpdk.org
Subject: Re: [PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet
Date: Sat, 19 Oct 2024 08:32:52 -0700 [thread overview]
Message-ID: <20241019083252.11352d7e@hermes.local> (raw)
In-Reply-To: <1729275230-16011-1-git-send-email-longli@linuxonhyperv.com>
On Fri, 18 Oct 2024 11:13:50 -0700
longli@linuxonhyperv.com wrote:
> icrosoft.com>
>
> The VSP assumes the packet doesn't have VLAN tags. When VLAN tag is
> present in a TX packet, always strip it and use PPI to send VLAN info
> through VSP packet.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: Hui (Hui) Ling <hling@SonicWall.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Wei Hu <weh@microsoft.com>
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
This was discovered from an network application that was using VLAN's
but not setting the offload bits in the mbuf.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-10-19 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 18:13 [PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet longli
2024-10-19 15:32 ` Stephen Hemminger [this message]
2024-10-26 3:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019083252.11352d7e@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hling@SonicWall.com \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.