From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 166DED3C900 for ; Sat, 19 Oct 2024 08:35:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C5F7340143; Sat, 19 Oct 2024 08:35:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rW4utqg3DDdB; Sat, 19 Oct 2024 08:35:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 096A54015D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1729326925; bh=uQX/jBEcvMr8h6e3JkJi6RZA97MBG1BERS4j5S3Xk8g=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=2/VLq/iFkPYXqPNiI6se1EQq1sBiT4WGDLtIdrmGTTVqmbPe8h5An5aDm7h/GZVXJ 25Ucqfa0BK2PPblpVFl+t+fwqwRQx6lp7dQKpfY7sW61h6HW5ISh6aAWQXMt8Fr1Sk E2SIAGVU3UeFVGMyOJ/alrF1ki05SqDV0Bg7Eirnmo4m9ZQ6Bd9geRmMN6a4UveOft VsYP+dDHfXxo3FITXzFFOyGX1CGA48UT+Xr07U+25Nr9e9+jcxMCmuPuYI0gz9UfWn /j7FMdoEt5fPivK8A1yUvttYM8LwtVkEvj+a3f/j2sx58yGzjqsqpgtSvMJxoV1tyI V7mJigFcz5YNQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 096A54015D; Sat, 19 Oct 2024 08:35:25 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id C4DF33A23 for ; Sat, 19 Oct 2024 08:35:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B2B324015D for ; Sat, 19 Oct 2024 08:35:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id y-pNElaAR2SW for ; Sat, 19 Oct 2024 08:35:23 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org E5E7D408B2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E5E7D408B2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp4.osuosl.org (Postfix) with ESMTPS id E5E7D408B2 for ; Sat, 19 Oct 2024 08:35:22 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D321FA40295; Sat, 19 Oct 2024 08:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95410C4CEC5; Sat, 19 Oct 2024 08:35:19 +0000 (UTC) Date: Sat, 19 Oct 2024 09:35:17 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Jacob Keller , Paul Greenwalt , Ahmed Zaki , Dan Nowlin , Michal Swiatkowski , Pucha Himasekhar Reddy Message-ID: <20241019083517.GK1697@kernel.org> References: <20241018141823.178918-4-przemyslaw.kitszel@intel.com> <20241018141823.178918-6-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241018141823.178918-6-przemyslaw.kitszel@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729326921; bh=zRFQMEYNsQS8URWjkAwCdUcTxZ2YaSxA6ImkdKBhBqM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NBJwaW41j8Ktq4XuagYkoRNWfTXac6uUfWWCsBCI0DqmmkTsttl60Z3sbw/fiN+PR m0anlfH/KcLvWl7qntLfU47j++nddyh3rKy4h4GHWwRwiDlIJjNoZqhlQsyZGW6OH1 QK6pQPw8v0YaEXGa6D3nm8sgjNKsRmIyG6zcyLm907WGZUiaAkEWra//jECzK461NK iQmH9v+zIdqybU/7WFUammaUxoOadiLF9AL4TJh8zwQ1o2MtL5fRNhsoSdO+QocLn9 fnseOZDvolp1RrghWeDD08A7xHpV+HC7dU1sqWMk+OqfGejJjmMZP3JwTVTwnf7wQa QUA15vC7Tnmqg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=NBJwaW41 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: support optional flags in signature segment header X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Oct 18, 2024 at 04:17:37PM +0200, Przemek Kitszel wrote: > An optional flag field has been added to the signature segment header. > The field contains two flags, a "valid" bit, and a "last segment" bit > that indicates whether the segment is the last segment that will be > sent to firmware. > > If the flag field's valid bit is NOT set, then as was done before, > assume that this is the last segment being downloaded. > > However, if the flag field's valid bit IS set, then use the last segment > flag to determine if this segment is the last segment to download. > > Signed-off-by: Paul Greenwalt > Signed-off-by: Ahmed Zaki > Co-developed-by: Dan Nowlin > Signed-off-by: Dan Nowlin > Reviewed-by: Michal Swiatkowski > Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) > Signed-off-by: Przemek Kitszel > --- > v2: co/- authorship change Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0323A1DC04B for ; Sat, 19 Oct 2024 08:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729326922; cv=none; b=XgtDrwn2PD+yd+lvqiptt6iD9ZaW9sXCn/eCkZ0noa5KQAlwMzsZNG4QtoFi3LP8ERMdnngQ5MHEDGd8R/1IUar50nDpiPLMNCDyO2+jbtZQ0ucoxKl7FT+B5/V1mgr9HA45cM420UxvCtWslU11dNkcVi15HyOF0vzS4uQwa/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729326922; c=relaxed/simple; bh=zRFQMEYNsQS8URWjkAwCdUcTxZ2YaSxA6ImkdKBhBqM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mCMYUo7aQTnoXzM19ORon9WW20BAa39I20uSOnslxs38v8F0sKL1sjz1Tunr5jgz3g74wQdWUOCYTLL6/FZN/jK6C78v2HdpNnN4xk+ScQ4zUa5jqwk3u8OaC5HsGrg381XMtstEOCUlvjl5VQKv7pIY89nEugaLZqhfTmyuBgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NBJwaW41; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NBJwaW41" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95410C4CEC5; Sat, 19 Oct 2024 08:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729326921; bh=zRFQMEYNsQS8URWjkAwCdUcTxZ2YaSxA6ImkdKBhBqM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NBJwaW41j8Ktq4XuagYkoRNWfTXac6uUfWWCsBCI0DqmmkTsttl60Z3sbw/fiN+PR m0anlfH/KcLvWl7qntLfU47j++nddyh3rKy4h4GHWwRwiDlIJjNoZqhlQsyZGW6OH1 QK6pQPw8v0YaEXGa6D3nm8sgjNKsRmIyG6zcyLm907WGZUiaAkEWra//jECzK461NK iQmH9v+zIdqybU/7WFUammaUxoOadiLF9AL4TJh8zwQ1o2MtL5fRNhsoSdO+QocLn9 fnseOZDvolp1RrghWeDD08A7xHpV+HC7dU1sqWMk+OqfGejJjmMZP3JwTVTwnf7wQa QUA15vC7Tnmqg== Date: Sat, 19 Oct 2024 09:35:17 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Jacob Keller , Paul Greenwalt , Ahmed Zaki , Dan Nowlin , Michal Swiatkowski , Pucha Himasekhar Reddy Subject: Re: [PATCH iwl-next v3 2/2] ice: support optional flags in signature segment header Message-ID: <20241019083517.GK1697@kernel.org> References: <20241018141823.178918-4-przemyslaw.kitszel@intel.com> <20241018141823.178918-6-przemyslaw.kitszel@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241018141823.178918-6-przemyslaw.kitszel@intel.com> On Fri, Oct 18, 2024 at 04:17:37PM +0200, Przemek Kitszel wrote: > An optional flag field has been added to the signature segment header. > The field contains two flags, a "valid" bit, and a "last segment" bit > that indicates whether the segment is the last segment that will be > sent to firmware. > > If the flag field's valid bit is NOT set, then as was done before, > assume that this is the last segment being downloaded. > > However, if the flag field's valid bit IS set, then use the last segment > flag to determine if this segment is the last segment to download. > > Signed-off-by: Paul Greenwalt > Signed-off-by: Ahmed Zaki > Co-developed-by: Dan Nowlin > Signed-off-by: Dan Nowlin > Reviewed-by: Michal Swiatkowski > Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) > Signed-off-by: Przemek Kitszel > --- > v2: co/- authorship change Reviewed-by: Simon Horman