All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/platform/cznic/turris-omnia-mcu-gpio.c:257 omnia_ctl_cmd_locked() error: uninitialized symbol 'len'.
Date: Sun, 20 Oct 2024 10:57:11 +0800	[thread overview]
Message-ID: <202410201033.sEvOUguy-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Marek Behún" <kabel@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>

Hi Marek,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   715ca9dd687f89ddaac8ec8ccb3b5e5a30311a99
commit: 74a22fced5a012c57f56d1cf7ea926cc366a2a3a platform: cznic: turris-omnia-mcu: Make poweroff and wakeup code optional
date:   2 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 2 months ago
config: arc-randconfig-r073-20241020 (https://download.01.org/0day-ci/archive/20241020/202410201033.sEvOUguy-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202410201033.sEvOUguy-lkp@intel.com/

smatch warnings:
drivers/platform/cznic/turris-omnia-mcu-gpio.c:257 omnia_ctl_cmd_locked() error: uninitialized symbol 'len'.

vim +/len +257 drivers/platform/cznic/turris-omnia-mcu-gpio.c

dfa556e45ae9ec Marek Behún 2024-07-01  232  
dfa556e45ae9ec Marek Behún 2024-07-01  233  static int omnia_ctl_cmd_locked(struct omnia_mcu *mcu, u8 cmd, u16 val, u16 mask)
dfa556e45ae9ec Marek Behún 2024-07-01  234  {
dfa556e45ae9ec Marek Behún 2024-07-01  235  	unsigned int len;
dfa556e45ae9ec Marek Behún 2024-07-01  236  	u8 buf[5];
dfa556e45ae9ec Marek Behún 2024-07-01  237  
dfa556e45ae9ec Marek Behún 2024-07-01  238  	buf[0] = cmd;
dfa556e45ae9ec Marek Behún 2024-07-01  239  
dfa556e45ae9ec Marek Behún 2024-07-01  240  	switch (cmd) {
dfa556e45ae9ec Marek Behún 2024-07-01  241  	case OMNIA_CMD_GENERAL_CONTROL:
dfa556e45ae9ec Marek Behún 2024-07-01  242  		buf[1] = val;
dfa556e45ae9ec Marek Behún 2024-07-01  243  		buf[2] = mask;
dfa556e45ae9ec Marek Behún 2024-07-01  244  		len = 3;
dfa556e45ae9ec Marek Behún 2024-07-01  245  		break;
dfa556e45ae9ec Marek Behún 2024-07-01  246  
dfa556e45ae9ec Marek Behún 2024-07-01  247  	case OMNIA_CMD_EXT_CONTROL:
dfa556e45ae9ec Marek Behún 2024-07-01  248  		put_unaligned_le16(val, &buf[1]);
dfa556e45ae9ec Marek Behún 2024-07-01  249  		put_unaligned_le16(mask, &buf[3]);
dfa556e45ae9ec Marek Behún 2024-07-01  250  		len = 5;
dfa556e45ae9ec Marek Behún 2024-07-01  251  		break;
dfa556e45ae9ec Marek Behún 2024-07-01  252  
dfa556e45ae9ec Marek Behún 2024-07-01  253  	default:
dfa556e45ae9ec Marek Behún 2024-07-01  254  		BUG();
dfa556e45ae9ec Marek Behún 2024-07-01  255  	}
dfa556e45ae9ec Marek Behún 2024-07-01  256  
dfa556e45ae9ec Marek Behún 2024-07-01 @257  	return omnia_cmd_write(mcu->client, buf, len);
dfa556e45ae9ec Marek Behún 2024-07-01  258  }
dfa556e45ae9ec Marek Behún 2024-07-01  259  

:::::: The code at line 257 was first introduced by commit
:::::: dfa556e45ae9ecc199e598222debc8f1883a7cce platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs

:::::: TO: Marek Behún <kabel@kernel.org>
:::::: CC: Arnd Bergmann <arnd@arndb.de>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2024-10-20  2:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20  2:57 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-07-19 18:38 drivers/platform/cznic/turris-omnia-mcu-gpio.c:257 omnia_ctl_cmd_locked() error: uninitialized symbol 'len' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410201033.sEvOUguy-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.