From: Uros Bizjak <ubizjak@gmail.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Uros Bizjak <ubizjak@gmail.com>, Dennis Zhou <dennis@kernel.org>,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 3/3] percpu: Cast percpu pointer in PERCPU_PTR() via unsigned long
Date: Mon, 21 Oct 2024 10:07:38 +0200 [thread overview]
Message-ID: <20241021080856.48746-3-ubizjak@gmail.com> (raw)
In-Reply-To: <20241021080856.48746-1-ubizjak@gmail.com>
Cast pointer from percpu address space to generic (kernel) address
space in PERCPU_PTR() macro via unsigned long intermediate cast [1].
This intermediate cast is also required to avoid build failure
when GCC's strict named address space checks for x86 targets [2]
are enabled.
Found by GCC's named address space checks.
[1] https://sparse.docs.kernel.org/en/latest/annotations.html#address-space-name
[2] https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html#x86-Named-Address-Spaces
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/percpu-defs.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/percpu-defs.h b/include/linux/percpu-defs.h
index e1cf7982424f..35842d1e3879 100644
--- a/include/linux/percpu-defs.h
+++ b/include/linux/percpu-defs.h
@@ -221,7 +221,10 @@ do { \
} while (0)
#define PERCPU_PTR(__p) \
- (typeof(*(__p)) __force __kernel *)(__p);
+({ \
+ unsigned long __pcpu_ptr = (__force unsigned long)(__p); \
+ (typeof(*(__p)) __force __kernel *)(__pcpu_ptr); \
+})
#ifdef CONFIG_SMP
--
2.47.0
next prev parent reply other threads:[~2024-10-21 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 8:07 [PATCH 1/3] percpu: Merge VERIFY_PERCPU_PTR() into its only user Uros Bizjak
2024-10-21 8:07 ` [PATCH 2/3] percpu: Introduce PERCPU_PTR() macro Uros Bizjak
2024-10-21 16:42 ` Christoph Lameter (Ampere)
2024-10-21 8:07 ` Uros Bizjak [this message]
2024-12-18 7:54 ` [PATCH 3/3] percpu: Cast percpu pointer in PERCPU_PTR() via unsigned long Gal Pressman
2024-12-18 8:40 ` Uros Bizjak
2024-12-18 8:46 ` Gal Pressman
2024-12-18 8:52 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021080856.48746-3-ubizjak@gmail.com \
--to=ubizjak@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.