All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] flock: Add negative tests for flock
Date: Mon, 21 Oct 2024 16:28:42 +0200	[thread overview]
Message-ID: <20241021142842.GA483032@pevik> (raw)
In-Reply-To: <1934768.7Z3S40VBb9@localhost>

Hi Yang Xu, Avinesh,

> Hi Yang Xu,


> When I am testing this by running multiple times, EINTR test is getting
> timed out randomly.

> tst_test.c:1625: TINFO: Timeout per run is 0h 00m 30s
> flock07.c:46: TINFO: Got SIGUSR1
> Test timeouted, sending SIGKILL!
> tst_test.c:1673: TINFO: Killed the leftover descendant processes
> tst_test.c:1679: TINFO: If you are running on slow machine, try exporting LTP_TIMEOUT_MUL > 1
> tst_test.c:1681: TBROK: Test killed! (timeout?)

> In these cases I see that there are two locks (held or waiting) by the process
> even after SIGUSER1 signal is delivered, so somehow signal is being ignored.

> flock07         16520  FLOCK        WRITE* 0          0          0 /tmp...
> flock07         16519  FLOCK        WRITE  0          0          0 /tmp...


> And I feel we should add EWOULDBLOCK errno test to flock02.c file,
> and keep only EINTR testcase here. 

There are v2 and v3 sent by Avinesh, therefore I set this in patchwork as
"Changes requested". Please correct me if I'm wrong.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-10-21 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  8:02 [LTP] [PATCH] flock: Add negative tests for flock Yang Xu via ltp
2024-05-30 14:13 ` Avinesh Kumar
2024-10-21 14:28   ` Petr Vorel [this message]
2024-05-30 14:40 ` [LTP] [PATCH v2] flock: Add test for verifying EINTR errno Avinesh Kumar
2024-05-30 14:48   ` [LTP] [PATCH v3] " Avinesh Kumar
2024-10-21 19:55     ` Petr Vorel
2025-01-14 15:54       ` Avinesh Kumar
2025-01-31 11:01         ` Petr Vorel
2025-02-03  9:41           ` Avinesh Kumar
2025-02-03 10:12             ` Petr Vorel
2025-02-03 14:22     ` Petr Vorel
2025-02-03 14:55       ` Avinesh Kumar
2025-02-03 15:33         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241021142842.GA483032@pevik \
    --to=pvorel@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.