From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-i2c@vger.kernel.org,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, kernel@dh-electronics.com
Subject: Re: [PATCH 1/2] dt-bindings: at24: add ST M24256E Additional Write lockable page support
Date: Mon, 21 Oct 2024 13:14:13 -0500 [thread overview]
Message-ID: <20241021181413.GA816269-robh@kernel.org> (raw)
In-Reply-To: <3aa9e2f4-b1ad-46bf-a8c3-0d57cd3a7075@denx.de>
On Sun, Oct 20, 2024 at 06:29:13AM +0200, Marek Vasut wrote:
> On 10/18/24 3:27 PM, Rob Herring wrote:
> > On Thu, Oct 17, 2024 at 08:41:25PM +0200, Marek Vasut wrote:
> > > The ST M24256E behaves as a regular M24C256, except for the E variant
> > > which uses up another I2C address for Additional Write lockable page.
> > > This page is 64 Bytes long and can contain additional data. Add entry
> > > for it, so users can describe that page in DT. Note that users still
> > > have to describe the main M24C256 area separately as that is on separate
> > > I2C address from this page.
> >
> > I think this should be modelled as 1 node having 2 addresses, not 2
> > nodes.
> We had the exact same discussion regarding M24C32D, see:
>
> https://lore.kernel.org/all/CAMRc=MdTu1gagX-L4_cHmN9aUCoKhN-b5i7yEeszKSdr+BuROg@mail.gmail.com/
Seems like kernel implementation details dictating the binding to me.
Won't be a problem until there are shared resources on "both" devices.
I guess since it is inline with what we already have:
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2024-10-21 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 18:41 [PATCH 1/2] dt-bindings: at24: add ST M24256E Additional Write lockable page support Marek Vasut
2024-10-17 18:41 ` [PATCH 2/2] eeprom: " Marek Vasut
2024-10-18 13:27 ` [PATCH 1/2] dt-bindings: " Rob Herring
2024-10-20 4:29 ` Marek Vasut
2024-10-21 18:14 ` Rob Herring [this message]
2024-10-21 18:35 ` Bartosz Golaszewski
2024-11-19 11:01 ` Geert Uytterhoeven
2024-11-19 12:04 ` Bartosz Golaszewski
2024-10-22 7:13 ` Bartosz Golaszewski
2024-10-22 7:14 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021181413.GA816269-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.