From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9C31FBC8D for ; Mon, 21 Oct 2024 20:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729541535; cv=none; b=MmlKyQ0O1dchYoAjCKyegLlFJRE4bw489zYz8DLBOy2chP8qIOH1f5IsJW971QaRa6/ZN+KVh9/rU/MNOjV+U7VcPqLM/wDA4EnrBTVNpWYIi0Z8qNSx1KvIy2d9skxlVhRikM2JUBAeVJrfe/seFFvMHJ7ZrtZ2Ilru7X1SRlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729541535; c=relaxed/simple; bh=vPMhi23LQjoIR0Hf8lQNXfi1dyp5IRY+HJUc6UNQf/w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bw3HCH2QRe/eGRvu5ngQIbqKsGb4q+xSojEYdUtIqBkV6PngY/AalzfXlBIEHdRbwDUx1MY0v6tXYdbR09sQh+xc4wUdu0darrJ+XVhFmcROB1Ls33Tfb54EHzDhiAxRKYvrpZzHtGeqtXXKwmvYZcB5I1CastdAN0/gVfmMhRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1M0KnGEx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1M0KnGEx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3697C4CEE6; Mon, 21 Oct 2024 20:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1729541535; bh=vPMhi23LQjoIR0Hf8lQNXfi1dyp5IRY+HJUc6UNQf/w=; h=From:To:Cc:Subject:Date:Reply-to:From; b=1M0KnGExgq0axwVrtQRjnlQQAIKS/NnYHt7N8gVF/+K4ZGsw4si9YUTxexBYcF1XJ jIGCAtkHeIXGxQ7uhIp8eQcM9H3jbEt3LXeKhE2lszZ8xqbrJTLH+wVyQQxFK783FW H3X4y+hrZ1k9qAp4rl8aAe0Hp4uHnizitFgUW/Ks= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-48997: char: tpm: Protect tpm_pm_suspend with locks Date: Mon, 21 Oct 2024 22:06:29 +0200 Message-ID: <2024102149-CVE-2022-48997-cd65@gregkh> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3237; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=vPMhi23LQjoIR0Hf8lQNXfi1dyp5IRY+HJUc6UNQf/w=; b=owGbwMvMwCRo6H6F97bub03G02pJDOliW2QNmmwXPLWfeqMlOkHkXnO++LPJC1UcHhYc6P+4Z Vmz0zbRjlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZhIezTDLOYdEvxvX1jn5no1 hl69kZkZ9d1nJsOCiXsln3zb8W2f8ocoi1lnJnVMOjy3BgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: char: tpm: Protect tpm_pm_suspend with locks Currently tpm transactions are executed unconditionally in tpm_pm_suspend() function, which may lead to races with other tpm accessors in the system. Specifically, the hw_random tpm driver makes use of tpm_get_random(), and this function is called in a loop from a kthread, which means it's not frozen alongside userspace, and so can race with the work done during system suspend: tpm tpm0: tpm_transmit: tpm_recv: error -52 tpm tpm0: invalid TPM_STS.x 0xff, dumping stack for forensics CPU: 0 PID: 1 Comm: init Not tainted 6.1.0-rc5+ #135 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-20220807_005459-localhost 04/01/2014 Call Trace: tpm_tis_status.cold+0x19/0x20 tpm_transmit+0x13b/0x390 tpm_transmit_cmd+0x20/0x80 tpm1_pm_suspend+0xa6/0x110 tpm_pm_suspend+0x53/0x80 __pnp_bus_suspend+0x35/0xe0 __device_suspend+0x10f/0x350 Fix this by calling tpm_try_get_ops(), which itself is a wrapper around tpm_chip_start(), but takes the appropriate mutex. [Jason: reworked commit message, added metadata] The Linux kernel CVE team has assigned CVE-2022-48997 to this issue. Affected and fixed versions =========================== Issue introduced in 5.1 with commit e891db1a18bf and fixed in 5.4.226 with commit d699373ac5f3 Issue introduced in 5.1 with commit e891db1a18bf and fixed in 5.10.158 with commit 4e0d6c687c92 Issue introduced in 5.1 with commit e891db1a18bf and fixed in 5.15.82 with commit 571b6bbbf54d Issue introduced in 5.1 with commit e891db1a18bf and fixed in 6.0.12 with commit 25b78bf98b07 Issue introduced in 5.1 with commit e891db1a18bf and fixed in 6.1 with commit 23393c646142 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-48997 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/char/tpm/tpm-interface.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/d699373ac5f3545243d3c73a1ccab77fdef8cec6 https://git.kernel.org/stable/c/4e0d6c687c925e27fd4bc78a2721d10acf5614d6 https://git.kernel.org/stable/c/571b6bbbf54d835ea6120f65575cb55cd767e603 https://git.kernel.org/stable/c/25b78bf98b07ff5aceb9b1e24f72ec0236c5c053 https://git.kernel.org/stable/c/23393c6461422df5bf8084a086ada9a7e17dc2ba