From: Christoph Hellwig <hch@lst.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: model freeze & enter queue as rwsem for supporting lockdep
Date: Tue, 22 Oct 2024 09:21:12 +0200 [thread overview]
Message-ID: <20241022072112.GA12249@lst.de> (raw)
In-Reply-To: <20241022071905.GB16066@noisy.programming.kicks-ass.net>
On Tue, Oct 22, 2024 at 09:19:05AM +0200, Peter Zijlstra wrote:
> > Not sure modelling it as a trylock is the right approach here,
> > I've added the lockdep maintainers if they have an idea.
>
> So lockdep supports recursive reader state, but you're looking at
> recursive exclusive state?
Yes.
> If you achieve this using an external nest count, then it is probably (I
> haven't yet had morning juice) sufficient to use the regular exclusive
> state on the outermost lock / unlock pair and simply ignore the inner
> locks.
There obviosuly is an external nest count here, so I guess that should
do the job. Ming?
next prev parent reply other threads:[~2024-10-22 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 1:35 [PATCH] block: model freeze & enter queue as rwsem for supporting lockdep Ming Lei
2024-10-18 16:57 ` Bart Van Assche
2024-10-21 2:20 ` Ming Lei
2024-10-22 6:26 ` Christoph Hellwig
2024-10-18 18:45 ` kernel test robot
2024-10-19 22:46 ` Jens Axboe
2024-10-21 11:17 ` Ming Lei
2024-10-22 6:18 ` Christoph Hellwig
2024-10-22 7:19 ` Peter Zijlstra
2024-10-22 7:21 ` Christoph Hellwig [this message]
2024-10-23 3:22 ` Ming Lei
2024-10-23 6:07 ` Christoph Hellwig
2024-10-22 15:05 ` Bart Van Assche
2024-10-23 7:59 ` Ming Lei
2024-10-23 18:05 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022072112.GA12249@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=boqun.feng@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.