Re: [PATCH v2 net-next 13/14] rtnetlink: Return int from rtnl_af_register().

[Simon Horman <horms@kernel.org>]

On Tue, Oct 22, 2024 at 10:53:32AM +0200, Paolo Abeni wrote:
> On 10/16/24 20:53, Kuniyuki Iwashima wrote:
> > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> > index 445e6ffed75e..70b663aca209 100644
> > --- a/net/core/rtnetlink.c
> > +++ b/net/core/rtnetlink.c
> > @@ -686,11 +686,13 @@ static const struct rtnl_af_ops *rtnl_af_lookup(const int family)
> >   *
> >   * Returns 0 on success or a negative error code.
> >   */
> > -void rtnl_af_register(struct rtnl_af_ops *ops)
> > +int rtnl_af_register(struct rtnl_af_ops *ops)
> >  {
> >  	rtnl_lock();
> >  	list_add_tail_rcu(&ops->list, &rtnl_af_ops);
> >  	rtnl_unlock();
> > +
> > +	return 0;
> >  }
> >  EXPORT_SYMBOL_GPL(rtnl_af_register);
> 
> kdoc complains about the missing description for the return value. You
> need to replace 'Returns' with '@return'.
> 
> Not blocking, but please follow-up.

FWIIW, I think "Return: " or "Returns: " also works.