From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:18c3:b0:1be9:327d:8ee3 with SMTP id tt3csp2942576njb; Tue, 22 Oct 2024 02:41:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUmUZEvZtgutnXEFvFUD2Cb3sqRVcFiKqJPl71EDo5dtTx+FeyFeeeOjukTKW3pdqU8i0fx9Ffk0bRDAQ==@linaro.org X-Google-Smtp-Source: AGHT+IHFIU8KsKT7BS6V/uJjNogujbmI3MmPWQJdQYJqLQKnsrne89urmQMi0qw2O7vY6VYoWqWV X-Received: by 2002:a05:6214:4b0d:b0:6cb:fff6:8f28 with SMTP id 6a1803df08f44-6cde15eb790mr245110106d6.40.1729590108471; Tue, 22 Oct 2024 02:41:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729590108; cv=none; d=google.com; s=arc-20240605; b=MmRaZM57OQenHBRklSnA4yT0muhgPC5TqQOU+qXlApUHduDCb9+e2ndyWo45Eu8TY0 yYfpTzKi4CnwBZAT06BeCg+7W0Xn3OF8gKfCXFyWSfFsvPp/1pQk3KCNpe6IJIFKnuiD 9ouc3KOP7U7L0rPaIljoYfd65FcQg6m6ItfcyEqDTXJ4TFdns1W0WJ5qmWuC1boLKQsR d++Vua9XRdmuekFzEkUW31Gx55xeXHIPIcF9CtRzH9aCMmGGsYKxSBsqb3uET3qO2RaM pcu1TW6eh3amlfO8ln901u7ODlYsnnNF2+yrO+N2zWxF1r95jtjshXwi7sgzk1fHr3d1 saMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:from:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to; bh=bhNOKIiByWSdJo/1/6RrMPBALmk4+ILYOaV+WUGPLUM=; fh=RVX+uUL/oYxgKlLpNyiQfzI75/ka+93kXvmeIy2Oap4=; b=asG5U0YfxG1+wrKpIXk/1sbbyFumbzfCzCghylJ2qzhRTAXFhsJsNpq6nf/e1OhO83 CWNs7K94QuH7XSWghTl8/py+yx1Mos4rlxStX8rq1t00ooJRkmLuH/ULOpUV9FAjDDkQ xzjRlMAoKQi1NGKBka7/qH77xOrnxNmdkO0LkSRyeNzc5yXHzzt4KffoEgtXuYpVFqWl pItqLP7pjxVGF9Q+Uv7HJjJ20zYh42d8Jin4mulYIG4pRLTkHwAkZxYM4EKxwcQnqfES 6W4AB0YtjpTMlbzyDCTDS4/3UaAqmz3f3RBL3NCPhCrNyOZtP+qqYuoK0dNrvNQg7HNx bZgQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ce009e2756si60988426d6.423.2024.10.22.02.41.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2024 02:41:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3BOO-0002nP-42; Tue, 22 Oct 2024 05:41:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOE-0002mi-Sw; Tue, 22 Oct 2024 05:41:24 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOC-00015E-4V; Tue, 22 Oct 2024 05:41:22 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 22 Oct 2024 17:41:11 +0800 Received: from localhost.localdomain (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Tue, 22 Oct 2024 17:41:10 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Alistair Francis , "Kevin Wolf" , Hanna Reitz , Thomas Huth , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" , "open list:Block layer core" CC: , , Subject: [PATCH v2 00/18] Fix write incorrect data into flash in user mode Date: Tue, 22 Oct 2024 17:40:52 +0800 Message-ID: <20241022094110.1574011-1-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: U5pgfdOoFKHN change from v1: 1. Fix write incorrect data into flash in user mode. 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 and AST1030. 3. Add ast2700 smc qtest testcase to support AST2700. change from v2: 1. Introduce a new aspeed-smc-utils.c to place common testcases. 2. Fix hardcode attach flash model of spi controllers 3. Add reviewers suggestion and fix review issue. QEMU version: https://github.com/qemu/qemu/commit/95a16ee753d6da651fce8df876333bf7fcf134d9 Depend patch series: To successfully apply this patch series, it is required to apply this patch series first, https://patchwork.kernel.org/project/qemu-devel/list/?series=894520 Jamin Lin (18): aspeed/smc: Fix write incorrect data into flash in user mode hw/block:m25p80: Fix coding style hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq hw/block/m25p80: Add SFDP table for w25q80bl flash hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB. hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB aspeed: Fix hardcode attach flash model of spi controllers test/qtest/aspeed_smc-test: Fix coding style test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs test/qtest/aspeed_smc-test: Support to test all CE pins test/qtest/aspeed_smc-test: Introducing a "page_addr" data field test/qtest/aspeed_smc-test: Support to test AST2500 test/qtest/aspeed_smc-test: Support to test AST2600 test/qtest/aspeed_smc-test: Support to test AST1030 test/qtest/aspeed_smc-test: Support write page command with QPI mode test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases test/qtest/ast2700-smc-test: Support to test AST2700 hw/arm/aspeed.c | 25 +- hw/block/m25p80.c | 63 ++- hw/block/m25p80_sfdp.c | 36 ++ hw/block/m25p80_sfdp.h | 2 +- hw/ssi/aspeed_smc.c | 40 +- include/hw/ssi/aspeed_smc.h | 1 + tests/qtest/aspeed-smc-utils.c | 681 +++++++++++++++++++++++++++++ tests/qtest/aspeed-smc-utils.h | 95 +++++ tests/qtest/aspeed_smc-test.c | 757 +++++++-------------------------- tests/qtest/ast2700-smc-test.c | 67 +++ tests/qtest/meson.build | 5 +- 11 files changed, 1143 insertions(+), 629 deletions(-) create mode 100644 tests/qtest/aspeed-smc-utils.c create mode 100644 tests/qtest/aspeed-smc-utils.h create mode 100644 tests/qtest/ast2700-smc-test.c -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02988D1CDCB for ; Tue, 22 Oct 2024 09:42:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3BOR-0002nv-Bg; Tue, 22 Oct 2024 05:41:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOE-0002mi-Sw; Tue, 22 Oct 2024 05:41:24 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOC-00015E-4V; Tue, 22 Oct 2024 05:41:22 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 22 Oct 2024 17:41:11 +0800 Received: from localhost.localdomain (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Tue, 22 Oct 2024 17:41:10 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Alistair Francis , "Kevin Wolf" , Hanna Reitz , Thomas Huth , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" , "open list:Block layer core" CC: , , Subject: [PATCH v2 00/18] Fix write incorrect data into flash in user mode Date: Tue, 22 Oct 2024 17:40:52 +0800 Message-ID: <20241022094110.1574011-1-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org change from v1: 1. Fix write incorrect data into flash in user mode. 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 and AST1030. 3. Add ast2700 smc qtest testcase to support AST2700. change from v2: 1. Introduce a new aspeed-smc-utils.c to place common testcases. 2. Fix hardcode attach flash model of spi controllers 3. Add reviewers suggestion and fix review issue. QEMU version: https://github.com/qemu/qemu/commit/95a16ee753d6da651fce8df876333bf7fcf134d9 Depend patch series: To successfully apply this patch series, it is required to apply this patch series first, https://patchwork.kernel.org/project/qemu-devel/list/?series=894520 Jamin Lin (18): aspeed/smc: Fix write incorrect data into flash in user mode hw/block:m25p80: Fix coding style hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq hw/block/m25p80: Add SFDP table for w25q80bl flash hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB. hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB aspeed: Fix hardcode attach flash model of spi controllers test/qtest/aspeed_smc-test: Fix coding style test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs test/qtest/aspeed_smc-test: Support to test all CE pins test/qtest/aspeed_smc-test: Introducing a "page_addr" data field test/qtest/aspeed_smc-test: Support to test AST2500 test/qtest/aspeed_smc-test: Support to test AST2600 test/qtest/aspeed_smc-test: Support to test AST1030 test/qtest/aspeed_smc-test: Support write page command with QPI mode test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases test/qtest/ast2700-smc-test: Support to test AST2700 hw/arm/aspeed.c | 25 +- hw/block/m25p80.c | 63 ++- hw/block/m25p80_sfdp.c | 36 ++ hw/block/m25p80_sfdp.h | 2 +- hw/ssi/aspeed_smc.c | 40 +- include/hw/ssi/aspeed_smc.h | 1 + tests/qtest/aspeed-smc-utils.c | 681 +++++++++++++++++++++++++++++ tests/qtest/aspeed-smc-utils.h | 95 +++++ tests/qtest/aspeed_smc-test.c | 757 +++++++-------------------------- tests/qtest/ast2700-smc-test.c | 67 +++ tests/qtest/meson.build | 5 +- 11 files changed, 1143 insertions(+), 629 deletions(-) create mode 100644 tests/qtest/aspeed-smc-utils.c create mode 100644 tests/qtest/aspeed-smc-utils.h create mode 100644 tests/qtest/ast2700-smc-test.c -- 2.34.1