All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gax-c <zichenxie0106@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, dinghao.liu@zju.edu.cn,
	arnd@arndb.de, scott.bauer@intel.com, kbusch@kernel.org,
	heinzm@redhat.com, snitzer@redhat.com,
	linux-mtd@lists.infradead.org, zzjas98@gmail.com,
	chenyuan0y@gmail.com
Subject: Re: [PATCH v2] mtd: diskonchip: Cast an operand to uint64_t to prevent potential uint32_t overflow in inftl_partscan()
Date: Tue, 22 Oct 2024 10:41:38 +0200	[thread overview]
Message-ID: <20241022104138.3f9de009@xps-13> (raw)
In-Reply-To: <20241021192753.8582-1-zichenxie0106@gmail.com>

Hi,

zichenxie0106@gmail.com wrote on Mon, 21 Oct 2024 14:27:54 -0500:

> From: Zichen Xie <zichenxie0106@gmail.com>
> 
> This was found by a static analyzer.

This should be the last sentence, not the first, maybe?

> There may be a potential integer overflow issue in
> inftl_partscan(). parts[0].size is defined as "uint64_t"
> while mtd->erasesize and ip->firstUnit are defined as 32-bit
> unsigned integer. The result of the calculation will be limited
> to 32 bits without correct casting.
> So, we recommend adding an extra cast to prevent potential
> integer overflow.

The wrapping is odd.

> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Zichen Xie <zichenxie0106@gmail.com>
> ---
> v2: correct "Fixes" tag.

If you want to provide a fix, you probably want to Cc: stable as well.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-10-22  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 19:27 [PATCH v2] mtd: diskonchip: Cast an operand to uint64_t to prevent potential uint32_t overflow in inftl_partscan() Gax-c
2024-10-22  8:41 ` Miquel Raynal [this message]
2024-10-22 15:49   ` Zichen Xie
2024-10-23  8:12     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022104138.3f9de009@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=chenyuan0y@gmail.com \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=heinzm@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=scott.bauer@intel.com \
    --cc=snitzer@redhat.com \
    --cc=vigneshr@ti.com \
    --cc=zichenxie0106@gmail.com \
    --cc=zzjas98@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.