All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: andrii@kernel.org, yhs@fb.com, jolsa@kernel.org,
	linux-kernel@vger.kernel.org
Cc: daniel@iogearbox.net, sean@mess.org
Subject: perf_event_detach_bpf_prog() broken?
Date: Tue, 22 Oct 2024 13:16:38 +0200	[thread overview]
Message-ID: <20241022111638.GC16066@noisy.programming.kicks-ass.net> (raw)

Hi guys,

Per commit 170a7e3ea070 ("bpf: bpf_prog_array_copy() should return
-ENOENT if exclude_prog not found") perf_event_detach_bpf_prog() can now
return without doing bpf_prog_put() and leaving event->prog set.

This is very 'unexpected' behaviour.

I'm not sure what's sane from the BPF side of things here, but leaving
event->prog set is really rather unexpected.

Help?

             reply	other threads:[~2024-10-22 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 11:16 Peter Zijlstra [this message]
2024-10-22 14:03 ` perf_event_detach_bpf_prog() broken? Jiri Olsa
2024-10-22 14:12   ` Sean Young
2024-10-22 21:08     ` Jiri Olsa
2024-10-22 17:33   ` Andrii Nakryiko
2024-10-23  8:19     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022111638.GC16066@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andrii@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sean@mess.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.