From: Simon Horman <horms@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: vburru@marvell.com, sedara@marvell.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] octeon_ep: Remove unneeded semicolon
Date: Tue, 22 Oct 2024 16:59:25 +0100 [thread overview]
Message-ID: <20241022155925.GZ402847@kernel.org> (raw)
In-Reply-To: <20241022063453.103751-1-yang.lee@linux.alibaba.com>
On Tue, Oct 22, 2024 at 02:34:53PM +0800, Yang Li wrote:
> This patch removes an unneeded semicolon after a while statement.
>
> ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:381:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11430
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Hi Yang Li,
While I agree that this change is correct, and improves the code.
Netdev discourages clean-ups along these lines that are not in
the context of other work [1].
[1] https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: not-applicable
prev parent reply other threads:[~2024-10-22 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 6:34 [PATCH -next] octeon_ep: Remove unneeded semicolon Yang Li
2024-10-22 15:59 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022155925.GZ402847@kernel.org \
--to=horms@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sedara@marvell.com \
--cc=vburru@marvell.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.