From: SeongJae Park <sj@kernel.org>
To: Zheng Yejian <zhengyejian@huaweicloud.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
foersleo@amazon.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, shakeel.butt@linux.dev, sieberf@amazon.com,
yeweihua4@huawei.com
Subject: Re: [PATCH v2 0/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()
Date: Tue, 22 Oct 2024 11:05:37 -0700 [thread overview]
Message-ID: <20241022180537.42492-1-sj@kernel.org> (raw)
In-Reply-To: <20241022083927.3592237-1-zhengyejian@huaweicloud.com>
Hi Zheng,
On Tue, 22 Oct 2024 16:39:25 +0800 Zheng Yejian <zhengyejian@huaweicloud.com> wrote:
[...]
> To fix it, count for each piece split and make sure no more than
> 'nr_pieces'. In addition, add above case into damon_test_split_evenly().
>
> And add 'nr_piece == 1' check in damon_va_evenly_split_region()
> for better code readability and add a corresponding kunit testcase.
>
> Zheng Yejian (2):
> mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()
> mm/damon/vaddr: Check 'nr_piece == 1' case in
> damon_va_evenly_split_region()
>
> mm/damon/tests/vaddr-kunit.h | 2 ++
> mm/damon/vaddr.c | 7 +++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
Thank you for addressing my comments and posting this new patch series. I
added my Reviewed-by: tags with some trivial comments to the patches.
Btw, at least on DAMON mailing list, we usually post new revisions as new
threads, rather than as a reply to the previous revision. If you want to make
sure involved people aware of the new series, you can send the lore link for
the new series as a reply to the previous revision.
Thanks,
SJ
next prev parent reply other threads:[~2024-10-22 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 3:53 [PATCH] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region() Zheng Yejian
2024-10-18 18:33 ` SeongJae Park
2024-10-21 3:56 ` Zheng Yejian
2024-10-21 16:33 ` SeongJae Park
2024-10-22 8:39 ` [PATCH v2 0/2] " Zheng Yejian
2024-10-22 8:39 ` [PATCH v2 1/2] " Zheng Yejian
2024-10-22 17:54 ` SeongJae Park
2024-10-22 18:00 ` SeongJae Park
2024-10-22 8:39 ` [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check " Zheng Yejian
2024-10-22 17:57 ` SeongJae Park
2024-10-22 18:05 ` SeongJae Park [this message]
2024-10-23 1:27 ` [PATCH v2 0/2] mm/damon/vaddr: Fix issue " Zheng Yejian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022180537.42492-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=foersleo@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
--cc=sieberf@amazon.com \
--cc=yeweihua4@huawei.com \
--cc=zhengyejian@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.