Re: [Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so it can be built with aarch64

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bryce,

On Tue, 22 Oct 2024 14:36:44 -0600
Bryce Johnson <bryce@redpinelabs.com> wrote:

> Yes I'll do that. Finally got the git send email with my gmail account
> working and thought the Signed-off-by got added.  I'll clean up that
> and the line length as well.

Thanks, I have seen your v2, which I have applied. However, did you see
the remainder of my review? See below.

> > > -ARM_GNU_TOOLCHAIN_SOURCE = arm-gnu-toolchain-$(ARM_GNU_TOOLCHAIN_VERSION)-x86_64-arm-none-eabi.tar.xz
> > > +ARM_GNU_TOOLCHAIN_SOURCE = arm-gnu-toolchain-$(ARM_GNU_TOOLCHAIN_VERSION)-$(HOSTARCH)-arm-none-eabi.tar.xz  
> >
> > The change looks correct as-is of course, as it doesn't make anything
> > worse. However, I believe to make things cleaner, we should perhaps
> > introduce a package/arm-gnu-toolchain/Config.in.host file, with a blind
> > option BR2_HOST_PACKAGE_ARM_GNU_TOOLCHAIN, that has a "depends on" the
> > host architectures that are supported. And the packages that use
> > host-arm-gnu-toolchain would have to be careful to propagate those
> > depends on, so that we do not allow using host-arm-gnu-toolchain on
> > configurations that do not allow using the host-arm-gnu-toolchain
> > package. However this can be done as a separate patch, as again your
> > change is not making things any worse than they already are :)
> >
> > Could you send a v2 of your patch with the proposed changes?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot