From: linux@treblig.org
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check
Date: Wed, 23 Oct 2024 00:29:34 +0100 [thread overview]
Message-ID: <20241022232934.238124-6-linux@treblig.org> (raw)
In-Reply-To: <20241022232934.238124-1-linux@treblig.org>
From: "Dr. David Alan Gilbert" <linux@treblig.org>
drm_client_modeset_check() was explicitly added in 2020 by
commit 64593f2a6fc9 ("drm/client: Add drm_client_modeset_check()")
but has never been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/drm_client_modeset.c | 24 ------------------------
include/drm/drm_client.h | 1 -
2 files changed, 25 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index cee5eafbfb81..69e1ce4d18cd 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -1126,30 +1126,6 @@ static int drm_client_modeset_commit_legacy(struct drm_client_dev *client)
return ret;
}
-/**
- * drm_client_modeset_check() - Check modeset configuration
- * @client: DRM client
- *
- * Check modeset configuration.
- *
- * Returns:
- * Zero on success or negative error code on failure.
- */
-int drm_client_modeset_check(struct drm_client_dev *client)
-{
- int ret;
-
- if (!drm_drv_uses_atomic_modeset(client->dev))
- return 0;
-
- mutex_lock(&client->modeset_mutex);
- ret = drm_client_modeset_commit_atomic(client, true, true);
- mutex_unlock(&client->modeset_mutex);
-
- return ret;
-}
-EXPORT_SYMBOL(drm_client_modeset_check);
-
/**
* drm_client_modeset_commit_locked() - Force commit CRTC configuration
* @client: DRM client
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index 560aae47e06d..e1fd32adb3e9 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -176,7 +176,6 @@ int drm_client_modeset_create(struct drm_client_dev *client);
void drm_client_modeset_free(struct drm_client_dev *client);
int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, unsigned int height);
bool drm_client_rotation(struct drm_mode_set *modeset, unsigned int *rotation);
-int drm_client_modeset_check(struct drm_client_dev *client);
int drm_client_modeset_commit_locked(struct drm_client_dev *client);
int drm_client_modeset_commit(struct drm_client_dev *client);
int drm_client_modeset_dpms(struct drm_client_dev *client, int mode);
--
2.47.0
next prev parent reply other threads:[~2024-10-22 23:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 23:29 [PATCH 0/5] DRM deadcode linux
2024-10-22 23:29 ` [PATCH 1/5] drm: Remove unused drm_atomic_helper_commit_planes_on_crtc linux
2024-10-28 13:16 ` Dmitry Baryshkov
2024-10-22 23:29 ` [PATCH 2/5] drm/sysfs: Remove unused drm_class_device_(un)register linux
2024-10-28 13:16 ` Dmitry Baryshkov
2024-10-22 23:29 ` [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time linux
2024-10-28 15:49 ` Dmitry Baryshkov
2024-10-28 16:13 ` Ville Syrjälä
2024-10-28 16:54 ` Dr. David Alan Gilbert
2024-10-22 23:29 ` [PATCH 4/5] drm/client: Remove unused drm_client_framebuffer_flush linux
2024-10-23 6:46 ` Thomas Zimmermann
2024-10-23 8:04 ` Jocelyn Falempe
2024-10-23 11:03 ` Dr. David Alan Gilbert
2024-10-22 23:29 ` linux [this message]
2024-10-28 13:24 ` [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check Dmitry Baryshkov
2024-10-28 13:52 ` Dr. David Alan Gilbert
2024-10-29 23:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022232934.238124-6-linux@treblig.org \
--to=linux@treblig.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.