From: Simon Horman <horms@kernel.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bareudp: Use pcpu stats to update rx_dropped counter.
Date: Wed, 23 Oct 2024 09:12:25 +0100 [thread overview]
Message-ID: <20241023081225.GK402847@kernel.org> (raw)
In-Reply-To: <959d4ea099039922e60efe738dd2172c87b5382c.1729257592.git.gnault@redhat.com>
On Fri, Oct 18, 2024 at 03:35:28PM +0200, Guillaume Nault wrote:
> Use the core_stats rx_dropped counter to avoid the cost of atomic
> increments.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
> ---
> I'm using core_stats for consistency with the vxlan implementation.
> If we really want to avoid using core_stats in tunnel drivers, just
> let me know and I'll convert bareudp to NETDEV_PCPU_STAT_DSTATS. But
> for the moment, I still prefer to favor code consistency across UDP
> tunnel implementations.
Hi Guillaume, all,
I think that this patch improves things and the suggestion above
can be treated as a possible follow-up.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-23 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 13:35 [PATCH net-next] bareudp: Use pcpu stats to update rx_dropped counter Guillaume Nault
2024-10-23 8:12 ` Simon Horman [this message]
2024-10-28 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023081225.GK402847@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.