From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Steve Sistare <steven.sistare@oracle.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Nicolin Chen <nicolinc@nvidia.com>
Subject: Re: [PATCH V5 8/9] iommufd: file mappings for mdev
Date: Wed, 23 Oct 2024 10:16:10 -0300 [thread overview]
Message-ID: <20241023131610.GF864191@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB5276E04633A8E0A3F877FFAB8C4D2@BN9PR11MB5276.namprd11.prod.outlook.com>
On Wed, Oct 23, 2024 at 08:01:56AM +0000, Tian, Kevin wrote:
> > From: Steve Sistare <steven.sistare@oracle.com>
> > Sent: Wednesday, October 23, 2024 5:01 AM
> >
> > @@ -1973,6 +1973,10 @@ static int iopt_pages_rw_page(struct iopt_pages
> > *pages, unsigned long index,
> > struct page *page = NULL;
> > int rc;
> >
> > + if (IS_ENABLED(CONFIG_IOMMUFD_TEST) &&
> > + WARN_ON(pages->type != IOPT_ADDRESS_USER))
> > + return -EINVAL;
> > +
>
> is this check necessary? if yes why is it only enabled in test?
This is the pattern for correctness assertions on performance paths
Jason
next prev parent reply other threads:[~2024-10-23 13:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 21:00 [PATCH V5 0/9] iommu_ioas_map_file Steve Sistare
2024-10-22 21:00 ` [PATCH V5 1/9] mm/gup: folio_add_pins Steve Sistare
2024-10-22 21:00 ` [PATCH V5 2/9] iommufd: rename uptr in iopt_alloc_iova Steve Sistare
2024-10-23 7:05 ` Tian, Kevin
2024-10-22 21:00 ` [PATCH V5 3/9] iommufd: generalize iopt_pages address Steve Sistare
2024-10-23 7:08 ` Tian, Kevin
2024-10-23 13:33 ` Steven Sistare
2024-10-22 21:00 ` [PATCH V5 4/9] iommufd: pfn reader local variables Steve Sistare
2024-10-23 7:09 ` Tian, Kevin
2024-10-22 21:00 ` [PATCH V5 5/9] iommufd: folio subroutines Steve Sistare
2024-10-23 7:16 ` Tian, Kevin
2024-10-23 7:21 ` Tian, Kevin
2024-10-23 13:03 ` Jason Gunthorpe
2024-10-24 6:14 ` Tian, Kevin
2024-10-23 13:04 ` Steven Sistare
2024-10-23 13:01 ` Jason Gunthorpe
2024-10-22 21:00 ` [PATCH V5 6/9] iommufd: pfn reader for file mappings Steve Sistare
2024-10-23 7:40 ` Tian, Kevin
2024-10-23 13:06 ` Steven Sistare
2024-10-24 6:17 ` Tian, Kevin
2024-10-23 13:15 ` Jason Gunthorpe
2024-10-23 13:24 ` Jason Gunthorpe
2024-10-22 21:00 ` [PATCH V5 7/9] iommufd: IOMMU_IOAS_MAP_FILE Steve Sistare
2024-10-23 7:45 ` Tian, Kevin
2024-10-23 13:22 ` Steven Sistare
2024-10-22 21:00 ` [PATCH V5 8/9] iommufd: file mappings for mdev Steve Sistare
2024-10-23 8:01 ` Tian, Kevin
2024-10-23 13:16 ` Jason Gunthorpe [this message]
2024-10-22 21:00 ` [PATCH V5 9/9] iommufd: map file selftest Steve Sistare
2024-10-23 13:52 ` Steven Sistare
2024-10-23 20:15 ` Nicolin Chen
2024-10-23 20:45 ` Steven Sistare
2024-10-24 0:36 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023131610.GF864191@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=nicolinc@nvidia.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.