From: Patrick Rudolph <patrick.rudolph@9elements.com>
To: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Bin Meng <bmeng.cn@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: [PATCH v10 09/37] acpi: acpi_table: Bump revisions
Date: Wed, 23 Oct 2024 15:19:52 +0200 [thread overview]
Message-ID: <20241023132116.970117-10-patrick.rudolph@9elements.com> (raw)
In-Reply-To: <20241023132116.970117-1-patrick.rudolph@9elements.com>
The FADT structure found in U-Boot represents FADT revision 6 and the
GICC and GICD structures defined in U-Boot are based on ACPI revision
6.3.
Bump the table revision to fix FWTS failures seen on aarch64.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/cpu/tangier/acpi.c | 2 --
include/acpi/acpi_table.h | 3 ++-
lib/acpi/acpi_table.c | 7 ++++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c
index 3d11787861..8ea764f7cc 100644
--- a/arch/x86/cpu/tangier/acpi.c
+++ b/arch/x86/cpu/tangier/acpi.c
@@ -28,8 +28,6 @@ void acpi_fill_fadt(struct acpi_fadt *fadt)
ACPI_FADT_POWER_BUTTON | ACPI_FADT_SLEEP_BUTTON |
ACPI_FADT_SEALED_CASE | ACPI_FADT_HEADLESS |
ACPI_FADT_HW_REDUCED_ACPI;
- fadt->header.revision = 6;
- fadt->minor_revision = 2;
}
void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx)
diff --git a/include/acpi/acpi_table.h b/include/acpi/acpi_table.h
index 7d994a985f..48f8ce248f 100644
--- a/include/acpi/acpi_table.h
+++ b/include/acpi/acpi_table.h
@@ -290,7 +290,8 @@ struct __packed acpi_fadt {
#define ACPI_MADT_REV_ACPI_3_0 2
#define ACPI_MADT_REV_ACPI_4_0 3
#define ACPI_MADT_REV_ACPI_5_0 3
-#define ACPI_MADT_REV_ACPI_6_0 5
+#define ACPI_MADT_REV_ACPI_6_2 4
+#define ACPI_MADT_REV_ACPI_6_3 5
#define ACPI_MCFG_REV_ACPI_3_0 1
diff --git a/lib/acpi/acpi_table.c b/lib/acpi/acpi_table.c
index 5b9b4d2f29..959cac9e2e 100644
--- a/lib/acpi/acpi_table.c
+++ b/lib/acpi/acpi_table.c
@@ -63,9 +63,9 @@ int acpi_get_table_revision(enum acpi_tables table)
{
switch (table) {
case ACPITAB_FADT:
- return ACPI_FADT_REV_ACPI_3_0;
+ return ACPI_FADT_REV_ACPI_6_0;
case ACPITAB_MADT:
- return ACPI_MADT_REV_ACPI_3_0;
+ return ACPI_MADT_REV_ACPI_6_2;
case ACPITAB_MCFG:
return ACPI_MCFG_REV_ACPI_3_0;
case ACPITAB_TCPA:
@@ -219,6 +219,7 @@ int acpi_write_fadt(struct acpi_ctx *ctx, const struct acpi_writer *entry)
memcpy(header->oem_table_id, OEM_TABLE_ID, 8);
memcpy(header->creator_id, ASLC_ID, 4);
header->creator_revision = 1;
+ fadt->minor_revision = 2;
fadt->x_firmware_ctrl = map_to_sysmem(ctx->facs);
fadt->x_dsdt = map_to_sysmem(ctx->dsdt);
@@ -254,7 +255,7 @@ int acpi_write_madt(struct acpi_ctx *ctx, const struct acpi_writer *entry)
/* Fill out header fields */
acpi_fill_header(header, "APIC");
header->length = sizeof(struct acpi_madt);
- header->revision = ACPI_MADT_REV_ACPI_3_0;
+ header->revision = acpi_get_table_revision(ACPITAB_MADT);
acpi_inc(ctx, sizeof(struct acpi_madt));
/* TODO: Get rid of acpi_fill_madt and use driver model */
--
2.46.2
next prev parent reply other threads:[~2024-10-23 13:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:19 [PATCH v10 00/37] Implement ACPI on aarch64 Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 01/37] acpi: x86: Move SPCR and DBG2 into common code Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 02/37] acpi: x86: Write FADT in " Patrick Rudolph
2024-11-07 9:19 ` Heinrich Schuchardt
2024-11-08 7:10 ` Patrick Rudolph
2024-11-08 11:19 ` Heinrich Schuchardt
2024-11-09 17:34 ` Simon Glass
2024-10-23 13:19 ` [PATCH v10 03/37] acpi: x86: Move MADT to " Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 04/37] acpi: Fix typo Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 05/37] serial: serial_pl01x: Implement .getinfo() for PL01 Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 06/37] acpi: Add define for GTDT Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 07/37] arm: acpi: Add generic ACPI methods Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 08/37] acpi: Add fill_madt to acpi_ops Patrick Rudolph
2024-10-23 13:19 ` Patrick Rudolph [this message]
2024-10-23 13:19 ` [PATCH v10 10/37] acpi: Add ACPITAB for PPTT and GTDT Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 11/37] acpi: acpi_table: Add IORT support Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 12/37] acpi: Move function prototype Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 13/37] acpi_table: Support platforms with unusable RSDT Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 14/37] acpi: Allocate and write ACPI tables Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 15/37] acpi: Add processor device Patrick Rudolph
2024-10-23 13:19 ` [PATCH v10 16/37] drivers: usb: Add generic XHCI Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 17/37] drivers: ata: Rename ahci_mvebu Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 18/37] drivers/cpu: Add generic armv8 cpu driver Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 19/37] arm: gic-v3-its: Rename objects Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 20/37] arm: gic-v3-its: Implement of_xlate Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 21/37] arm: lib: Add GICV2 driver Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 22/37] drivers: misc: irq-uclass: Update irq_get_by_index Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 23/37] drivers/arm: Implement acpi_fill_madt Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 24/37] common: Enable BLOBLIST_TABLES on arm Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 25/37] board: emulation: Add QEMU sbsa support Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 26/37] arm: mach-bcm283x: Map the ARM local MMIO as well Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 27/37] arm: mach-bcm283x: Bring in some header files from tianocore Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 28/37] arm: bcm283x: Generate ACPI tables Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 29/37] board: raspberrypi: Add ASL files from tianocore Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 30/37] arm: cpu: Add ACPI parking protocol support Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 31/37] armv8: cpu: Enable ACPI parking protocol Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 32/37] arm: Implement read_mpidr on armv7 Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 33/37] arm: mach-bcm283x: Add ARMV8_MULTIENTRY support Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 34/37] arm: mach-bcm283x: Enable ARMV8_MULTIENTRY Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 35/37] bloblist: Fix use of uninitialized variable Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 36/37] configs: Add RPI4 ACPI defconfig Patrick Rudolph
2024-10-23 13:20 ` [PATCH v10 37/37] CI: Enable qemu_sbsa Patrick Rudolph
2024-10-28 2:53 ` [PATCH v10 00/37] Implement ACPI on aarch64 Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023132116.970117-10-patrick.rudolph@9elements.com \
--to=patrick.rudolph@9elements.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.