All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Niklas Cassel via buildroot <buildroot@buildroot.org>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
	Kilian Zinnecker <kilian.zinnecker@mail.de>,
	Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH v4] configs/rock5b: enable uboot-env on the SD card
Date: Wed, 23 Oct 2024 21:53:47 +0200	[thread overview]
Message-ID: <20241023215347.15ca78ea@windsurf> (raw)
In-Reply-To: <20241023182509.2808544-1-niklas.cassel@wdc.com>

On Wed, 23 Oct 2024 20:25:09 +0200
Niklas Cassel via buildroot <buildroot@buildroot.org> wrote:

> From: Niklas Cassel <cassel@kernel.org>
> 
> Having the uboot environment defined on the SD card allows the user to
> use the uboot setenv and saveenv commands to make persistent changes
> (e.g. to change the boot order, or to set a server IP for PXE boot).
> 
> Set the uboot-env partition type GUID to "U-Boot environment", see:
> https://github.com/u-boot/u-boot/blob/v2024.10/doc/README.gpt#L288
> https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
> and enable CONFIG_PARTITION_TYPE_GUID such that uboot will automatically
> find the SD card partition to store/load the uboot environment to.
> 
> We need to mark the root partition as bootable, otherwise uboot will no
> longer be able to boot the partition by default. (Most likely because
> the root partition is now no longer the first partition on the device.)
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> Changes since v3:
> -Use partition type GUID to specify the partition to use, rather than
>  hardcoding an offset using uboot Kconfig CONFIG_ENV_OFFSET.

Nice solution: applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-23 19:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 18:25 [Buildroot] [PATCH v4] configs/rock5b: enable uboot-env on the SD card Niklas Cassel via buildroot
2024-10-23 19:53 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023215347.15ca78ea@windsurf \
    --to=buildroot@buildroot.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=kilian.zinnecker@mail.de \
    --cc=niklas.cassel@wdc.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.