Re: [Buildroot] [PATCH] utils/brmake: add option to run in docker

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 23 Oct 2024 14:22:34 +0200
Arnout Vandecappelle via buildroot <buildroot@buildroot.org> wrote:

> At the moment, it is difficult to combine brmake with docker-run.
> `docker-run brmake ...` doesn't work because our docker image doesn't
> have unbuffer. In addition, inside the container the timezone is UTC,
> but you probably want the timestamps added by brmake to be in local
> time. Therefore, it's better to have the call to docker-run nested
> inside brmake.
> 
> Currently, brmake doesn't have any way to pass parameters, all of "$@"
> is passed unchanged to the `make` invocation. Thus, there is no
> established way to pass in the option whether or not to use docker. We
> choose to use an environment variable to pass in the option. The
> convention is that such a buildroot-specific environment variable should
> start with BR2_, so we choose BR2_DOCKER.
> 
> Run make inside docker-run if the BR2_DOCKER environment variable is
> set. Update utils/readme.txt (the only existing documentation of brmake)
> with this information.
> 
> Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
> ---
>  utils/brmake     | 8 +++++++-
>  utils/readme.txt | 3 +++
>  2 files changed, 10 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot