From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
zlang@kernel.org, dchinner@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: remove the post-EOF prealloc tests from the auto and quick groups
Date: Thu, 24 Oct 2024 08:24:39 +0200 [thread overview]
Message-ID: <20241024062439.GA32468@lst.de> (raw)
In-Reply-To: <ZxltWrUxkeuRq2I8@dread.disaster.area>
On Thu, Oct 24, 2024 at 08:40:42AM +1100, Dave Chinner wrote:
> On Wed, Oct 23, 2024 at 10:23:51AM -0700, Darrick J. Wong wrote:
> > On Wed, Oct 23, 2024 at 12:39:30PM +0200, Christoph Hellwig wrote:
> > > These fail for various non-default configs like DAX, alwayscow and
> > > small block sizes.
> >
> > Shouldn't we selectively _notrun these tests for configurations where
> > speculative/delayed allocations don't work?
>
> Perhaps turning off speculative delalloc by adding the mount
> option "-o allocsize=<1 fsb>" to these tests would result in them
> always have the same behaviour?
But it also kinda defeats what they are trying to test? At least
that's my understanding, but your wrote them, though..
next prev parent reply other threads:[~2024-10-24 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 10:39 [PATCH] xfs: remove the post-EOF prealloc tests from the auto and quick groups Christoph Hellwig
2024-10-23 17:23 ` Darrick J. Wong
2024-10-23 21:40 ` Dave Chinner
2024-10-24 6:24 ` Christoph Hellwig [this message]
2024-10-24 6:25 ` Christoph Hellwig
2024-10-24 13:24 ` Zorro Lang
2025-03-12 6:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024062439.GA32468@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.